Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add support for image data in prompt logging #92

Open
luca-medeiros opened this issue Nov 8, 2023 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@luca-medeiros
Copy link

Introduction:

With the introduction of the gpt4v API, it becomes increasingly important to expand the capabilities of the library to accommodate other modality data in prompt logging.

Rationale:

Including image data in prompts can significantly enhance the tracking ability, enabling users to evaluate text-based responses based on visual input too. At first glance, I thought about adding image_path/s3 uri to the metadata but would be awesome if we could see the image on the UI directly.

Feasibility Assessment:

Would like to request feedback from the development team regarding the feasibility of implementing this feature. Are there any technical challenges or considerations I should be aware of?

Contribution Interest:

I'm eager to contribute to this feature's development. If the team finds it feasible, could you provide pointers on where to start contributing? Any guidance or documentation would be greatly appreciated.

@jverre
Copy link
Contributor

jverre commented Nov 14, 2023

Hi Luca,
Great suggestion !

Last week we pushed a new version of the SDK that integrates with v1 of the OpenAI SDK. We should now be auto logging the link to the image automatically.

Having the image render in the UI would be a good improvement. Since this repo is just for the SDK code, it will be something we have to build internally so I've raised it with the team.

We can keep you updated on our progress here and also let you know if there are other features you could contribute to.

@luca-medeiros
Copy link
Author

luca-medeiros commented Nov 27, 2023

Hey @jverre would love to know when this gets implemented. (would migrate all code from smith to comet)

We should now be auto logging the link to the image automatically.

where is the image hosted?

@Danselem
Copy link

Hi @jverre,

Still looking forward to the feature.

I'm also interested in knowing if one can implement comet ml log_image function into comet llm log_prompt.

Let me know what you think.

@dsblank dsblank added the enhancement New feature or request label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants