Allow only one of input or default in MathBinary #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
praj-0
commented
Dec 28, 2022
praj-0
commented
- Input validation for MathBinary pyspark transformer to allow only one of input column or default value
- Issue:MathBinary input validation #840
- Unit testing done
austinzh
reviewed
Dec 28, 2022
| @@ -89,6 +89,10 @@ def __init__( | |||
| # | |||
| # if operation is not None, we can proceed to instantiate the scala classes | |||
| if operation: | |||
| if (inputA and defaultA is not None) or \ | |||
There was a problem hiding this comment.
It's better if we check the final product of params.
Because user can set params in __init__, setParams, and set it one by one.
Most user actually prefer set it one by one like.
binaryMathBinary().setOpertion(BinaryOperation.Multiply).setInputA("aa").setInputB("bb").setDefaultA(1).setDefaultB(2)
praj-0
force-pushed
the
u/praj/math_binary_input_validation
branch
from
f51be17
to
e993d3e
Compare
austinzh
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.