Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Some) nonstandard color spaces error when round-tripping #433

Closed
LeaVerou opened this issue Feb 13, 2024 · 4 comments · Fixed by #439
Closed

(Some) nonstandard color spaces error when round-tripping #433

LeaVerou opened this issue Feb 13, 2024 · 4 comments · Fixed by #439
Labels
bug Something isn't working
Milestone

Comments

@LeaVerou
Copy link
Member

LeaVerou commented Feb 13, 2024

This is a blocker for v0.5.0 as it's a pretty serious regression Turns out this exists in v0.4.3 too 🤦🏽‍♀️

Try this in the console:

new Color(new Color("red").to("p3-linear").toString())
image
@LeaVerou LeaVerou added the REGRESSION Something used to work but now it doesn’t label Feb 13, 2024
@LeaVerou LeaVerou added this to the v0.5.0 milestone Feb 13, 2024
@LeaVerou
Copy link
Member Author

LeaVerou commented Feb 13, 2024

I think we should parse both forms in v0.5.0 to ease the transition, and just print out a warning when using unprefixed ids for nonstandard spaces.

Otherwise it's a breaking change, and a pretty significant one at that.

@lloydk
Copy link
Collaborator

lloydk commented Feb 14, 2024

I don't think this is a regression but a case of missing formats. I tested the 0.45 and 0.43 releases and had the same problem.

I created a PR for the missing formats #435.

@LeaVerou
Copy link
Member Author

Thanks for working on this @lloydk! I left a comment in the PR, but if this issue is present in the previous release as well, then it's not a blocker.

@jgerigmeyer jgerigmeyer changed the title REGRESSION: (Some) nonstandard color spaces error when round-tripping (Some) nonstandard color spaces error when round-tripping Feb 14, 2024
@jgerigmeyer jgerigmeyer added bug Something isn't working and removed REGRESSION Something used to work but now it doesn’t labels Feb 14, 2024
@jgerigmeyer
Copy link
Member

I proposed a slightly larger fix for this in #439.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants