Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can Click on a block in preview to see its configuration appear in sidepanel #23

Closed
2 of 3 tasks
Tracked by #4
MAX-786 opened this issue May 24, 2024 · 4 comments · Fixed by #51 or #95
Closed
2 of 3 tasks
Tracked by #4

I can Click on a block in preview to see its configuration appear in sidepanel #23

MAX-786 opened this issue May 24, 2024 · 4 comments · Fixed by #51 or #95
Assignees

Comments

@MAX-786
Copy link
Member

MAX-786 commented May 24, 2024

  • don't select two blocks if one block is inside another
  • Try to make the listening to the click events as robust as possible so the integrator can't accidentally prevent it from happening
  • don't require the integrator to do anything other than add the block ids to the blocks
@djay
Copy link
Member

djay commented Jun 17, 2024

@MAX-786 as disussed should be able to do it by adding data attributes without having to call an extra api

@djay
Copy link
Member

djay commented Jul 5, 2024

@MAX-786 there is one problem with this one. If you are on the order tab it won't switch to the block settings if you click on a new block in preview

maybe create new ticket?

@djay djay reopened this Jul 5, 2024
@MAX-786
Copy link
Member Author

MAX-786 commented Jul 5, 2024

Thanks for pointing it out!
Let me see if the fix is complicated or just some single redux action dispatch.
I'll do it accordingly.

@MAX-786
Copy link
Member Author

MAX-786 commented Jul 5, 2024

Its an easy fix i'll create a new PR and merge it right away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants