feat: make attachment type field list configurable in config #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM..do we need also a fix on the backend, right? |
cekk
approved these changes
Mar 3, 2023
|
No, the backend already handles this, with this fix what we do to have the widget list configurable, otherwise only the field whose widget is "attachment" is sent as an attachment. In our case, we have prepared more widgets to attach files, and we need to be able to signal that are attachments. |
pnicolli
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now only the field type "attachment" is sent as attachment to the back-end endpoint.
This these changes, we make the attachment field list configurable at block level, to be able to add additional field types there, for instance, those that can be added as additional fields with additional checks or whatever.