Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dep on volto-subblocks #49

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Add missing dep on volto-subblocks #49

merged 1 commit into from
Feb 6, 2023

Conversation

sneridagh
Copy link
Member

This is breaking builds with 3.0.0 and latest Volto. Workaround is explicitly add the dep in your projects.

It would be great to have a release soon! Thanks!

@sneridagh sneridagh linked an issue Nov 13, 2022 that may be closed by this pull request
@pnicolli
Copy link
Member

pnicolli commented Feb 6, 2023

I am still not 100% sold about this, but the demand for this has grown so I am merging it, I will give it some more thought later on if it will be possibile.

@pnicolli pnicolli merged commit 90f605b into main Feb 6, 2023
@pnicolli pnicolli deleted the fixdeps branch February 6, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

volto-subblocks is not included as dependency
3 participants