Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dexterity needs another interface #41

Closed
frisi opened this issue Jun 12, 2014 · 3 comments
Closed

Dexterity needs another interface #41

frisi opened this issue Jun 12, 2014 · 3 comments

Comments

@frisi
Copy link
Member

frisi commented Jun 12, 2014

currently for dexterity types you'll need to implement another interface (IImageCroppingScale) as archetypes (IImageCropping)

(see #21 (comment))

maybe we can find a way to make both work with the same single marker interface.
or we move IImageCroppingScale to plone.app.imagecropping.interfaces.dexterity.IImageCropping

anyway we should also document this in the readme so people know how to properly use it
(most stuff will work with iimagecropping, but the improvements for the lost scales (ticket #21) will not work.

@saily
Copy link
Member

saily commented Jun 12, 2014

While refactoring the whole thing yesterday it came in my mind that for example IImageCroppingBehavior should be available to mark dexterity items as croppable. Why not implementing that one as a behavior?

@frisi
Copy link
Member Author

frisi commented Jun 12, 2014

that's a great idea.

@jensens
Copy link
Member

jensens commented Sep 2, 2014

meanwhile i at least split up the crazyness of mixture between at/dx a bit, now it should be very easy to make a behaviour here too. I'all open a new issue marked as enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants