Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draghandle missing in collective.easyform 4.0.0 #341

Open
Nimo-19 opened this issue May 23, 2022 · 4 comments
Open

Draghandle missing in collective.easyform 4.0.0 #341

Nimo-19 opened this issue May 23, 2022 · 4 comments

Comments

@Nimo-19
Copy link
Contributor

Nimo-19 commented May 23, 2022

Issue description

After I updated to Version 4.0.0 I noticed that the Draghandles on fields in the 'define form fields' action are missing.
Therefore I can not reorder the fields in this view.

Steps to reproduce the issue

  1. Install minimal plone 5.2.8 buildout and add easyform
  2. Create a form
  3. Choose the action 'define form fields'

What's the expected result?

  • The Drag handle to be present

What's the actual result?

  • No Drag Handles are present

Additional details / screenshot

Versions
Plone 5.2.8 (5216)
CMF 2.5.4
Zope 4.8.1
Python 3.7.12 (default, Mar 14 2022, 07:11:45) [GCC 11.2.0]
PIL 6.2.2 (Pillow)
WSGI: On
Server: waitress 2.1.1
collective.easyform: 4.0.0
Screenshot

Drag-Handle-Missing-4 0 0

@fredvd
Copy link
Member

fredvd commented Jun 17, 2022

This is a regression from 3.X . For a customer project I have/had an interim version of collective.easyform 3.1.0.devX last built on March 7th 2022 which is I think also what is now still on the 3.x branch.

@pbauer @frapell You added Plone 6.0 support to main after the 3.x branch was split of for maintenance, but the changelog for 4.0.0 still explicitly says 5.2 is supported.

@fredvd
Copy link
Member

fredvd commented Jun 17, 2022

@pbauer @mauritsvanrees maybe we should release a 3.1.0 for Plone 5.2 from the 3.x branch for now and remove the claim that 4.0 is still compatible with 5.2 . 3.X It contains all updates in 4.0.0 except the field and other updates for Plone 6.0 compatiblity (according to the changelog)

@mauritsvanrees
Copy link
Member

3.1.0 was already released in April. Apparently I was the one who did that, without pushing the commits to GitHub. Something must have gone wrong there. Sorry!
See commit 039eff8 where @maethu fixed this, thanks.
For good measure, I will fix the history in CHANGES.rst and make a 3.1.1 release with the latest changes.

I tried adding CI to the 3.x branch, copied from what Fred did on master, but that does not work yet. See #355

For the current bug about the drag handle missing, I confirm on Plone 5.2 it works on branch 3.x and fails on master. For me it would be fine to let 3.x target only Plone 5 (my CI PR does this already, because locally the Plone 6 jobs had more errors than the others) and let master only be for Plone 6. The presumption here is that it is tricky for a package like collective.easyform to have a branch that works on both 5.2 and 6, especially if we want the Plone 6 experience to be optimal, with Bootstrap 5, and maybe module federation.

@mauritsvanrees
Copy link
Member

I have released 3.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants