Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Covers cannot link to other cover items? #892

Open
fredvd opened this issue Sep 8, 2021 · 3 comments
Open

Covers cannot link to other cover items? #892

fredvd opened this issue Sep 8, 2021 · 3 comments

Comments

@fredvd
Copy link
Member

fredvd commented Sep 8, 2021

We're still maintaining a few cover installations and one of the webmasters asked us this week why he cannot select a cover as a target in for example the content chooser.

Covers are not selectable as linkable items in the cover control panel and the vocabulary feeding the control panel field explicitly fiters out the cover CT:

items = [i for i in items if i.token != 'collective.cover.content']

(at

items = [i for i in items if i.token != 'collective.cover.content']
)

But why can't a cover link to another cover? Is something recursive being triggered? Or is it only there to also avoid linking to the same cover? The line seems to be there since the first import to github almost 10 years ago.

@hvelarde
Copy link
Member

hvelarde commented Sep 9, 2021

I don't know and I don't think @frapell remembers why he did so in first place.

just go ahead if you think it's a valid use case.

@frapell
Copy link
Member

frapell commented Sep 9, 2021

@hvelarde The vocabulary was introduced in 9f74a8d by you :)

I have no idea why covers were specifically excluded

@hvelarde
Copy link
Member

hvelarde commented Sep 9, 2021

then I don't remember :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants