Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dependency on plone.app.relationfield #684

Closed
alecghica opened this issue Nov 22, 2016 · 2 comments · Fixed by #809
Closed

Remove unnecessary dependency on plone.app.relationfield #684

alecghica opened this issue Nov 22, 2016 · 2 comments · Fixed by #809

Comments

@alecghica
Copy link
Member

alecghica commented Nov 22, 2016

Right now collective.cover depends on plone.app.relationfield which can easily made optional. This (unused?) dependency brings more problems than benefits and can be added independently if needed.

Problem is that plone.app.relationfield is dependent of plone.app.intid which, on install, loops through the whole catalog and does a getObject on each brain:

... this operation will never succeed if you have a medium or large database already, with ten of thousand of objects/brains for example and you will never be able to install the collective.cover.

Removing dependency of plone.app.relationfield can be done easily by removing the followings:

@hvelarde
Copy link
Member

a PR is highly appreciated; plaase document what to do on upgrades to not break current installations, the same we did with other hard dependencies we have been removing in the last months.

@alecghica
Copy link
Member Author

I won't have the time for this in the near future so anyone interested in adding a pull request for this is welcomed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants