Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha 12 breaks adding a Collection to a Carousel tile #574

Closed
davilima6 opened this issue Dec 18, 2015 · 4 comments · Fixed by #591
Closed

Alpha 12 breaks adding a Collection to a Carousel tile #574

davilima6 opened this issue Dec 18, 2015 · 4 comments · Fixed by #591
Assignees
Labels

Comments

@davilima6
Copy link
Contributor

Steps to reproduce:

  1. Add and publish some news items.
  2. In Compose view/tab, drag default News collection into a Carousel Tile. It gets green, spinner is briefly displayed but content doesn't get updated. Also noticed there's success (200) for @@updatetilecontent?tile-type=collective.cover.carousel when item is dropped.
@davilima6 davilima6 added the bug label Dec 18, 2015
@hvelarde
Copy link
Member

@davilima6 I think that never worked; the carousel tile inherits from list tile and you have to drop individual items with images: https://github.com/collective/collective.cover/blob/master/src/collective/cover/tiles/carousel.py#L58:L69

@hvelarde
Copy link
Member

now I understand; @rodfersou please take a look on this later.

@rodfersou
Copy link
Member

When we drop a collection or a folder into list or caroussel tile, it adapts the content into a list of items and never update it's content after that.

Should we review it to update the collection or list automatically?

This could be a new feature that could be turned on or off with a configuration flag.

I just need to keep reference of original object dropped to make this kind of check, and it will work just for tiles configured after this new feature (now we don't keep this reference).

@hvelarde
Copy link
Member

@rodfersou that's not what @davilima6 is reporting; he says what you state in paragraph 1 is not true for carousels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants