Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new asyncio.all_tasks if available #187

Merged
merged 1 commit into from
May 15, 2019
Merged

Conversation

dirk-thomas
Copy link
Member

To avoid deprecation warning in Python 3.7+:

colcon_core\executor\sequential.py:94: PendingDeprecationWarning: Task.all_tasks() is deprecated, use asyncio.all_tasks() instead

@dirk-thomas dirk-thomas added the review Waiting for review (Kanban column) label May 10, 2019
@dirk-thomas dirk-thomas self-assigned this May 10, 2019
@codecov-io
Copy link

codecov-io commented May 10, 2019

Codecov Report

Merging #187 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
+ Coverage   78.03%   78.06%   +0.02%     
==========================================
  Files          53       53              
  Lines        3051     3055       +4     
  Branches      511      511              
==========================================
+ Hits         2381     2385       +4     
  Misses        642      642              
  Partials       28       28
Impacted Files Coverage Δ
colcon_core/executor/sequential.py 95.65% <100%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7670fd5...add8cc7. Read the comment docs.

Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should clean up the warnings coming out of the Fedora rawhide RPM builds for colcon.

@dirk-thomas dirk-thomas added this to the 0.3.21 milestone May 15, 2019
@dirk-thomas dirk-thomas merged commit 7dad6d7 into master May 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the all_tasks_deprecation branch May 15, 2019 16:17
@dirk-thomas dirk-thomas removed the review Waiting for review (Kanban column) label May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants