Skip to content
This repository has been archived by the owner on Feb 11, 2021. It is now read-only.

fix #67 Redux reset appearance #73

Merged
merged 6 commits into from
Sep 2, 2017
Merged

Conversation

codekiln
Copy link
Owner

@codekiln codekiln commented Sep 2, 2017

No description provided.

@codekiln codekiln added this to the v0.2 - redux milestone Sep 2, 2017
@codekiln codekiln self-assigned this Sep 2, 2017
@codekiln
Copy link
Owner Author

codekiln commented Sep 2, 2017

The build issues for 2cd153a and 5bf49fb are with node-sass. One common solution is to add a postinstall key to the package.json which rebuilds node-sass. npm has an ability to rebuild just one package, but right now, it looks like the closest thing is yarn install --force, which rebuilds everything, and I'm not yet sure how to configure Travis CI to do that at the beginning.

I have seen a number of github issues raised because node-sass doesn't work with yarn: yarnpkg/yarn#1981 is one raised in the yarn repo.

I also see that it looks like it is using an old version of yarn on travis ci:

46.24s$ yarn
yarn install v0.17.8
[1/4] Resolving packages...

Yarn recommends installing yarn yourself if you override the install step in .travis.yml, but I am not.

Travis has more info on this:

Downstream of that last issue was a notification that yarn will be upgraded in a coming 2017-09-06 update to the ubuntu trusty image: https://docs.travis-ci.com/user/build-environment-updates/2017-09-06/. After reading another recent blog post about the trusty rollout, realized that one can specify the distribution in the .travis.yml file

I'll try using dist: trusty, and see if that helps resolve the node-sass issue.

@codekiln
Copy link
Owner Author

codekiln commented Sep 2, 2017

It looks like until next week, sudo: required, group: edge is the only combination that works to load the latest yarn with the bugfix for node-sass's postinstall requirement. Unfortunately, as you can see in the Travis CI environment reference, the sudo: required image is a VM that requires 20-50s to boot, as compared with the sudo: false environment, which is container-based and only requires 1-6s to boot. When the new trusty environments are rolled out for container testing, I'll switch back to sudo: false for the faster build times.

@codekiln codekiln merged commit 8d6fb51 into release/0.2 Sep 2, 2017
@codekiln codekiln deleted the redux_-_reset_appearance_#67 branch September 2, 2017 11:53
@codekiln codekiln mentioned this pull request Sep 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant