Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cl make --store to realize the functionality of cl replicate #4356

Merged
merged 32 commits into from
Mar 9, 2023
Merged

Support cl make --store to realize the functionality of cl replicate #4356

merged 32 commits into from
Mar 9, 2023

Conversation

wwwjn
Copy link
Contributor

@wwwjn wwwjn commented Jan 18, 2023 •
edited
Loading

Reasons for making this change

Extend cl make to have cl replicate function, which let user move a bundle from one bundle storage to another bundle storage.

Related issues

Fix issue #3922

Screenshots

Checklist

  • I've added a screenshot of the changes, if this is a frontend change
  • I've added and/or updated tests, if this is a backend change
  • I've run the pre-commit.sh script
  • I've updated docs, if needed

@wwwjn
Copy link
Contributor Author

wwwjn commented Jan 18, 2023

TODO: add more tests for "cl make"

@wwwjn wwwjn requested a review from epicfaace January 25, 2023 21:30
@wwwjn wwwjn linked an issue Jan 28, 2023 that may be closed by this pull request
Implement "cl replicate" CLI command #3922
Closed
epicfaace
epicfaace requested changes Feb 1, 2023
View reviewed changes
Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far!

codalab/bundles/make_bundle.py Outdated Show resolved Hide resolved
codalab/lib/bundle_cli.py Show resolved Hide resolved
codalab/lib/bundle_cli.py Show resolved Hide resolved
codalab/lib/bundle_cli.py Outdated Show resolved Hide resolved
codalab/lib/bundle_cli.py Outdated Show resolved Hide resolved
codalab/server/bundle_manager.py Outdated Show resolved Hide resolved
codalab/server/bundle_manager.py Outdated Show resolved Hide resolved
codalab/server/bundle_manager.py Show resolved Hide resolved
tests/cli/test_cli.py Outdated Show resolved Hide resolved
tests/cli/test_cli.py Outdated Show resolved Hide resolved
wwwjn and others added 11 commits February 6, 2023 12:47
@wwwjn @epicfaace
Update codalab/lib/bundle_cli.py
93e75f2 
Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com>
@wwwjn @epicfaace
Update codalab/lib/bundle_cli.py
9e7c7e3 
Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com>
@wwwjn @epicfaace
Update codalab/bundles/make_bundle.py
8b0c1bc 
Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com>
@wwwjn @epicfaace
Update codalab/server/bundle_manager.py
c560f45 
Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com>
@wwwjn
fix comment
9a5f3a1
@wwwjn
fix format
5ec87e9
@wwwjn
Merge branch 'cl-replicate' of github.com:codalab/codalab-worksheets …
6b387e0 
…into cl-replicate
@wwwjn @epicfaace
Update tests/cli/test_cli.py
a0e8337 
Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com>
@wwwjn
Merge branch 'cl-replicate' of github.com:codalab/codalab-worksheets …
72428c4 
…into cl-replicate
@wwwjn
fix commits
45e8a7b
@wwwjn
fix format
ef4dab7
@wwwjn wwwjn requested a review from epicfaace February 7, 2023 07:39
epicfaace
epicfaace reviewed Feb 8, 2023
View reviewed changes
codalab/lib/upload_manager.py Show resolved Hide resolved
codalab/rest/bundles.py Show resolved Hide resolved
codalab/server/bundle_manager.py Outdated Show resolved Hide resolved
codalab/server/bundle_manager.py Show resolved Hide resolved
codalab/server/bundle_manager.py Outdated Show resolved Hide resolved
codalab/server/bundle_manager.py Outdated Show resolved Hide resolved
codalab/server/bundle_manager.py Show resolved Hide resolved
codalab/server/bundle_manager.py Show resolved Hide resolved
@wwwjn wwwjn requested a review from epicfaace February 21, 2023 05:13
epicfaace
epicfaace approved these changes Mar 1, 2023
View reviewed changes
codalab/lib/bundle_cli.py Outdated Show resolved Hide resolved
codalab/lib/bundle_cli.py Outdated Show resolved Hide resolved
codalab/lib/bundle_cli.py Outdated Show resolved Hide resolved
codalab/rest/bundles.py Show resolved Hide resolved
codalab/rest/bundles.py Show resolved Hide resolved
codalab/server/bundle_manager.py Show resolved Hide resolved
codalab/server/bundle_manager.py Show resolved Hide resolved
codalab/server/bundle_manager.py Show resolved Hide resolved
@wwwjn wwwjn merged commit c1e638e into master Mar 9, 2023
@wwwjn wwwjn deleted the cl-replicate branch March 9, 2023 00:25
@yifanmai yifanmai mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epicfaace epicfaace epicfaace approved these changes

@percyliang percyliang Awaiting requested review from percyliang

@AndrewJGaut AndrewJGaut Awaiting requested review from AndrewJGaut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement "cl replicate" CLI command
2 participants
@wwwjn @epicfaace