schema: remove sequence management for serial fields #98
Conversation
timgraham
force-pushed
the
no-sequence-change
branch
3 times, most recently
from
adf186f
to
8427f64
Compare
This is a copy of the method from the postgresql backend with the sequence delete/create/set statements removed. fix cockroachdb#83
timgraham
force-pushed
the
no-sequence-change
branch
from
8427f64
to
bbff400
Compare
| col_type = "integer" if new_type.lower() == "serial" else "bigint" | ||
| return ( | ||
| ( | ||
| self.sql_alter_column_type % { |
There was a problem hiding this comment.
just a question -- shouldn't the new column also have DEFAULT unique_rowid() in order to get the desired behavior?
There was a problem hiding this comment.
The test where I saw an error is this one which changes AutoField to BigAutoField: https://github.com/django/django/blob/7552de7866dcd270a0f353b007b4aceaa7f3ff3e/tests/schema/tests.py#L659-L676
I verified that the primary keys at the end of the migration are randomly generated. I also tested the reverse (BigAutoField to AutoField) and the IDs are as expected. I'm not sure about the inner workings of cockraockdb but maybe the default expression isn't affected by the ALTER statement?
Incidentally, only AutoField has DEFAULT unique_rowid() right now:
However, I removed those lines and behavior remains the same... without them, Django uses
serial, so I guess cockroachdb treats serial equivalent to integer DEFAULT unique_rowid().
BigAutoField uses bigserial from PostgreSQL but perhaps it should be made more explicit like AutoField. The docs say, "SERIAL is provided only for compatibility with PostgreSQL. New applications should use real data types and a suitable DEFAULT expression".
smallserial also uses unique_rowid() which seems broken as described in #84.
There was a problem hiding this comment.
so I guess cockroachdb treats serial equivalent to integer DEFAULT unique_rowid()
Yeah that is correct. So altering to a SERIAL type should be OK.
| col_type = "integer" if new_type.lower() == "serial" else "bigint" | ||
| return ( | ||
| ( | ||
| self.sql_alter_column_type % { |
There was a problem hiding this comment.
so I guess cockroachdb treats serial equivalent to integer DEFAULT unique_rowid()
Yeah that is correct. So altering to a SERIAL type should be OK.
This is a copy of the method from the postgresql backend with
the sequence delete/create/set statements removed.
fix #83