Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Committer vs Maintainer #33

Closed
parispittman opened this issue May 23, 2020 · 2 comments
Closed

Committer vs Maintainer #33

parispittman opened this issue May 23, 2020 · 2 comments

Comments

@parispittman
Copy link
Contributor

parispittman commented May 23, 2020

Goals for this issue:

  • list where we see the use of committer and maintainer; try and identify intent
  • decide if one should be used over the other or in certain applications
  • spark ideas around a role definition bank or FAQ or the like

Possible solution:

  • Go with the definitions in the #Resources list; opt for maintainer in most cases as its more inclusive to all “trusted” committers and not just the only code committer misconception. It would also match with projects submitting MAINTAINERS.md to requirements and projects can still define committer as part of their contributor roles.

Why we need clarity:

Uses:

Resources:

Notes:

  • to throw another wrench, Kubernetes doesn’t use either term. Approver and sub project owner would be the closest.
  • contributor is a close word but seems to have general consensus on usage and definition
  • some people say they are interchangeable. Discuss.
@jberkus
Copy link
Contributor

jberkus commented Jun 8, 2020

Argument:

We shouldn't use either word. We should use "project leader" instead.

"Committer": in the age of github, this term is without a clear definition. Who's a committer? It also strongly implies that code contributors are the only contributors who count.

"Maintainer": the CNCF has already made this term unusable via their official Maintainer list, whose criteria for inclusion is not project leadership. In many cases, everyone who ever contributed to the project is on that list. We can't change that.

For most uses of either term, what we care about is project leadership. For example, for "maintainer diversity", what we really care about is whether or not the project leadership is diverse enough to prevent the project from being 100% hostage to one specific company's business strategy -- not who's writing the code.

@jberkus
Copy link
Contributor

jberkus commented Jul 20, 2021

The TOC isn't interested in this, so closing.

@jberkus jberkus closed this as completed Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants