HLTTauDQM: support for PatTau ref objects #45648

slehti · 2024-08-06T12:38:13Z

PR description:

Added a creation of pat taus and using them as offline reference objects. That way we can have tau discriminators available, and better offline tau reference object selection.

The DQM plots contain now two sets, one with default medium working point tau against jet selection, and another with decayModeFinding only. The latter plots are named with string 'LowPurity'.

As the offline tau selection changes, expecting differences between new and old plots, however, old plots and new low purity plots should be identical.

cmsbuild · 2024-08-06T12:38:38Z

cms-bot internal usage

cmsbuild · 2024-08-06T12:41:11Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45648/41174

cmsbuild · 2024-08-06T12:41:33Z

A new Pull Request was created by @slehti for master.

It involves the following packages:

DQMOffline/Trigger (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@Fedespring, @HuguesBrun, @cericeci, @jhgoh, @missirol, @mmusich, @mtosi, @rociovilar, @trocino this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2024-08-06T16:19:21Z

@cmsbuild, please test

cmsbuild · 2024-08-06T18:23:28Z

-1

Failed Tests: RelVals RelVals-INPUT
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-228323/40804/summary.html
COMMIT: 9cd6573
CMSSW: CMSSW_14_1_X_2024-08-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45648/40804/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

4.22

----- Begin Fatal Exception 06-Aug-2024 18:48:08 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 160960 lumi: 277 event: 10001082 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Prefetching for module HLTTauRefProducer/'TauRefProducerLowPurity'
   [3] Calling method for module PATTauProducer/'patTaus'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::BaseTau
Looking for module label: hpsPFTauProducer
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

8.0

----- Begin Fatal Exception 06-Aug-2024 18:49:55 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Prefetching for module HLTTauRefProducer/'TauRefProducerLowPurity'
   [3] Calling method for module PATTauProducer/'patTaus'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::BaseTau
Looking for module label: hpsPFTauProducer
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

7.3

----- Begin Fatal Exception 06-Aug-2024 18:51:19 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 509 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Prefetching for module HLTTauRefProducer/'TauRefProducerLowPurity'
   [3] Calling method for module PATTauProducer/'patTaus'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::BaseTau
Looking for module label: hpsPFTauProducer
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log
134.813134.813_RunCosmics2015C/step2_RunCosmics2015C.log
136.733136.733_RunCosmics2016B/step2_RunCosmics2016B.log

Expand to see more relval errors ...

cmsbuild · 2024-08-27T08:10:21Z

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

slehti · 2024-08-29T07:20:13Z

Tested this PR with 2024G, and it worked. Tried to test with 2011A Cosmics, but it seems the files are only on tape with no user access. How to proceed with this PR?

mmusich · 2024-08-29T07:22:56Z

How to proceed with this PR?

I would suggest trying one of the workflows that failed, e.g.: runTheMatrix.py - l 7.3 --ibeos

cmsbuild · 2024-09-10T13:56:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45648/41727

cmsbuild · 2024-09-10T13:57:05Z

Pull request #45648 was updated. @antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

mmusich · 2024-09-10T14:01:27Z

@cmsbuild, please test

cmsbuild · 2024-09-10T17:52:00Z

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-228323/41441/summary.html
COMMIT: 279a67e
CMSSW: CMSSW_14_2_X_2024-09-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45648/41441/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 624 lines to the logs
Reco comparison results: 164 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3331158
DQMHistoTests: Total failures: 6349
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3324789
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1778.4330000000002 KiB( 43 files compared)
DQMHistoSizes: changed ( 1000.0 ): 24.534 KiB HLT/TAU
DQMHistoSizes: changed ( 12834.0,... ): 247.036 KiB HLT/TAU
DQMHistoSizes: changed ( 139.001 ): 7.742 KiB HLT/TAU
DQMHistoSizes: changed ( 4.22,... ): 5.635 KiB HLT/TAU
Checked 193 log files, 163 edm output root files, 44 DQM output files
TriggerResults: no differences found

antoniovagnerini · 2024-09-13T13:33:15Z

DQMOffline/Trigger/python/HLTTauDQMOffline_cfi.py

                            ),
                            doPFTaus = cms.untracked.bool(True),
                            ptMin = cms.untracked.double(15.0),
                            etaMin = cms.untracked.double(-2.5),
                            etaMax = cms.untracked.double(2.5),
                            phiMin = cms.untracked.double(-3.15),
                            phiMax = cms.untracked.double(3.15),
-                            PFTauProducer = cms.untracked.InputTag("hpsPFTauProducer")
+                            #PFTauProducer = cms.untracked.InputTag("hpsPFTauProducer")


Is this commented out line really needed, if not please remove

antoniovagnerini · 2024-09-13T14:14:09Z

@slehti can you provide any link to the validation plots for this PR ?

antoniovagnerini · 2024-09-24T07:32:03Z

gentle ping @slehti to provide the PR validation plots

slehti · 2024-10-03T13:43:36Z

Here are some plots for the L2tau efficiency. However, runTheMatrix.py keeps giving errors, and i'm out of ideas how to make it work.
Figure 1: Offline tau selection with old AOD decayModeFinding vs new AOD decayModeFindingNewDMs
Figure 2: Offline tau selection with AOD decayModeFindingNewDMs vs Pat decayModeFindingNewDMs
Figure 3: Offline tau selection with Pat decayModeFindingNewDMs vs new low purity tau
Figure 4: Offline tau selection with Pat decayModeFindingNewDMs vs new tau
So, old tau plots correspond to new low purity tau plots.
New tau plots vs old tau plots: changes expected, as the tau selection uses also a tau id discriminator, available in Pat taus.

cmsbuild · 2024-10-03T13:48:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45648/42042

cmsbuild · 2024-10-03T13:48:26Z

Pull request #45648 was updated. @antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

antoniovagnerini · 2024-10-03T14:22:14Z

please test

cmsbuild · 2024-10-03T16:48:55Z

-1

Failed Tests: RelVals RelVals-INPUT
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-228323/41919/summary.html
COMMIT: 6792b7d
CMSSW: CMSSW_14_2_X_2024-10-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45648/41919/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

4.22

----- Begin Fatal Exception 03-Oct-2024 17:13:29 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 160960 lumi: 277 event: 10001082 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Prefetching for module HLTTauRefProducer/'TauRefProducerLowPurity'
   [3] Calling method for module PATTauProducer/'patTaus'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::BaseTau
Looking for module label: hpsPFTauProducer
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

8.0

----- Begin Fatal Exception 03-Oct-2024 17:15:27 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Prefetching for module HLTTauRefProducer/'TauRefProducerLowPurity'
   [3] Calling method for module PATTauProducer/'patTaus'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::BaseTau
Looking for module label: hpsPFTauProducer
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

7.3

----- Begin Fatal Exception 03-Oct-2024 17:16:42 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 509 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Prefetching for module HLTTauRefProducer/'TauRefProducerLowPurity'
   [3] Calling method for module PATTauProducer/'patTaus'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::BaseTau
Looking for module label: hpsPFTauProducer
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

4.224.22_RunCosmics2011A/step2_RunCosmics2011A.log
134.813134.813_RunCosmics2015C/step2_RunCosmics2015C.log
136.733136.733_RunCosmics2016B/step2_RunCosmics2016B.log

Expand to see more relval errors ...

HLTTauDQM: support for PatTau ref objects

9cd6573

cmsbuild added this to the CMSSW_14_1_X milestone Aug 6, 2024

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending code-checks-pending labels Aug 6, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 6, 2024

cmsbuild added tests-started and removed tests-pending labels Aug 6, 2024

cmsbuild added tests-rejected and removed tests-started labels Aug 6, 2024

cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 27, 2024

cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 29, 2024

HLTTauRefProducer: separate input parameter for pat taus

279a67e

cmsbuild removed tests-rejected code-checks-approved labels Sep 10, 2024

cmsbuild added the code-checks-pending label Sep 10, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 10, 2024

cmsbuild added tests-started and removed tests-pending labels Sep 10, 2024

cmsbuild added tests-approved and removed tests-started labels Sep 10, 2024

antoniovagnerini reviewed Sep 13, 2024

View reviewed changes

HLTTauDQMOffline_cfi: PFTauProducer->PatTauProducer

6792b7d

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Oct 3, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 3, 2024

cmsbuild added tests-started and removed tests-pending labels Oct 3, 2024

cmsbuild added tests-rejected and removed tests-started labels Oct 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HLTTauDQM: support for PatTau ref objects #45648

HLTTauDQM: support for PatTau ref objects #45648

slehti commented Aug 6, 2024

cmsbuild commented Aug 6, 2024 •

edited

Loading

cmsbuild commented Aug 6, 2024

cmsbuild commented Aug 6, 2024

mmusich commented Aug 6, 2024

cmsbuild commented Aug 6, 2024

cmsbuild commented Aug 27, 2024

slehti commented Aug 29, 2024

mmusich commented Aug 29, 2024

cmsbuild commented Sep 10, 2024

cmsbuild commented Sep 10, 2024

mmusich commented Sep 10, 2024

cmsbuild commented Sep 10, 2024

antoniovagnerini Sep 13, 2024

antoniovagnerini commented Sep 13, 2024

antoniovagnerini commented Sep 24, 2024

slehti commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

antoniovagnerini commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

HLTTauDQM: support for PatTau ref objects #45648

Are you sure you want to change the base?

HLTTauDQM: support for PatTau ref objects #45648

Conversation

slehti commented Aug 6, 2024

PR description:

cmsbuild commented Aug 6, 2024 • edited Loading

cmsbuild commented Aug 6, 2024

cmsbuild commented Aug 6, 2024

mmusich commented Aug 6, 2024

cmsbuild commented Aug 6, 2024

RelVals

RelVals-INPUT

cmsbuild commented Aug 27, 2024

slehti commented Aug 29, 2024

mmusich commented Aug 29, 2024

cmsbuild commented Sep 10, 2024

cmsbuild commented Sep 10, 2024

mmusich commented Sep 10, 2024

cmsbuild commented Sep 10, 2024

Comparison Summary

antoniovagnerini Sep 13, 2024

Choose a reason for hiding this comment

antoniovagnerini commented Sep 13, 2024

antoniovagnerini commented Sep 24, 2024

slehti commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

antoniovagnerini commented Oct 3, 2024

cmsbuild commented Oct 3, 2024

RelVals

RelVals-INPUT

cmsbuild commented Aug 6, 2024 •

edited

Loading