Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] Testing Python formatting workflow with cmsbot #45616

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Benedikttk
Copy link

As previously discussed at the CoreSoftware meeting at 30/Jul,2024: indico link . This PR aims to test python code quality checks in the CMSSW infrastructure and is not meant to be merged: testing of Python formatting workflow with cmsbot is being implemented.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2024

A new Pull Request was created by @Benedikttk for master.

It involves the following packages:

  • FWCore/Framework (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@aandvalenzuela
Copy link
Contributor

code-checks

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2024

@aandvalenzuela
Copy link
Contributor

code-checks

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2024

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

INFO: We're applying PEP8 formatting to CMSSW using Ruff; while Ruff found formatting errors in the PR's Python files, this non-blocking check may flag untouched lines, so feel free to contribute by applying the suggested patch.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #45616 was updated. @Dr15Jones, @antoniovagnerini, @cmsbuild, @consuegs, @makortel, @nothingface0, @perrotta, @rvenditti, @saumyaphor4252, @smuzaffar, @syuvivida, @tjavaid can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

INFO: We're applying PEP8 formatting to CMSSW using Ruff; while Ruff found formatting errors in the PR's Python files, this non-blocking check may flag untouched lines, so feel free to contribute by applying the suggested patch.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

INFO: We're applying PEP8 formatting to CMSSW using Ruff; while Ruff found formatting errors in the PR's Python files, this non-blocking check may flag untouched lines, so feel free to contribute by applying the suggested patch.

@cmsbuild
Copy link
Contributor

Pull request #45616 was updated. @Dr15Jones, @antoniovagnerini, @cmsbuild, @consuegs, @makortel, @nothingface0, @perrotta, @rvenditti, @saumyaphor4252, @smuzaffar, @syuvivida, @tjavaid can you please check and sign again.

@cmsbuild
Copy link
Contributor

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

@antoniovilela
Copy link
Contributor

ping (to make bot change milestone)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants