Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry/CommonTopologies/interface/GeometryAligner.h should be moved #45619

Closed
Dr15Jones opened this issue Aug 1, 2024 · 11 comments
Closed

Comments

@Dr15Jones
Copy link
Contributor

DataFormats packages are allowed to depend on Geometry/CommonTopologies. The header GeometryAligner.h has dependencies on CondFormats and is the only reason Geometry/CommonTopologies (and therefore a number of DataFormats) package depends on CondFormats.

@Dr15Jones
Copy link
Contributor Author

assign Geometry/CommonTopologies

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2024

New categories assigned: geometry

@Dr15Jones,@civanch,@bsunanda,@makortel,@mdhildreth you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2024

A new Issue was created by @Dr15Jones.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor

bsunanda commented Aug 2, 2024

Either it could be moved to Alignment/CommonAlignment or moved to a new pckage CommonAlignment in Geometry

@bsunanda
Copy link
Contributor

bsunanda commented Aug 2, 2024

Most likely the second solution will be better. Asking for a new package Geometry/CommonAlignment. Please suggest

@bsunanda
Copy link
Contributor

bsunanda commented Aug 2, 2024

@Dr15Jones @makortel @civanch Please look at my comment and suggest

@makortel
Copy link
Contributor

makortel commented Aug 2, 2024

After poking a bit of what currently depends on GeometryAligner.h and the existing dependencies of various Geometry packages, I agree a new package would make most sense. I let others comment if CommonAlignment would be a good name (my feeling is "not necessarily", but I don't have anything significantly better to suggest, except maybe Geometry/GeometryAligner or something like that).

bsunanda pushed a commit to bsunanda/cmssw that referenced this issue Aug 3, 2024
cmsbuild added a commit that referenced this issue Aug 12, 2024
Run3 gex180: Move GeometryAligner.h from Geometry/CommonTopologies to Geometry/GeometryAligner to address issue #45619
@makortel
Copy link
Contributor

+geometry

GeometryAligner.h was moved in #45628

@makortel
Copy link
Contributor

@cmsbuild, please close

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

youngwan-kim pushed a commit to youngwan-kim/cmssw that referenced this issue Sep 11, 2024
jyoti299 pushed a commit to jyoti299/cmssw that referenced this issue Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants