Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong behaviour in makeTrackValidationPlots.py #45594

Open
lguzzi opened this issue Jul 30, 2024 · 4 comments
Open

wrong behaviour in makeTrackValidationPlots.py #45594

lguzzi opened this issue Jul 30, 2024 · 4 comments

Comments

@lguzzi
Copy link
Contributor

lguzzi commented Jul 30, 2024

I spotted a possible bug affecting makeTrackValidationPlots.py when printing to disk validation plots of HLT track collections.

To reproduce the bug:

cmsDriver.py DQM                                \
  --step VALIDATION:hltMultiTrackValidation     \
  --conditions 140X_mcRun4_realistic_v4         \
  --datatier DQMIO                              \
  --era Phase2C17I13M9                          \
  --eventcontent DQM                            \
  --filein file:/eos/cms/store/mc/Phase2Spring24DIGIRECOMiniAOD/DYToLL_M-10To50_TuneCP5_14TeV-pythia8/GEN-SIM-DIGI-RAW-MINIAOD/PU200ALCA_pilot_140X_mcRun4_realistic_v4-v1/130000/ab6e271f-1c82-49c2-b015-608d9f26eb0d.root \
  --fileout "file:DQM.root"                     \
  --geometry Extended2026D110                   \
  --nThreads 5                                  \
  --number 5

cmsDriver.py HARVEST                                \
  --step HARVESTING:@trackingOnlyValidation+@trackingOnlyDQM+postProcessorHLTtrackingSequence \
  --filein file:DQM.root                            \
  --scenario pp                                     \
  --filetype DQM                                    \
  --conditions 140X_mcRun4_realistic_v4             \
  --mc

makeTrackValidationPlots.py DQM_V0001_R000000001__Global__CMSSW_X_Y_Z__RECO.root -o plots

I would expect the script to plot the content of the following TDirectories

DQMData/Run 1/HLT/Run summary/Tracking/ValidationWRTtp/hltPhase2Pixel_hltAssociatorByHits
DQMData/Run 1/HLT/Run summary/Tracking/ValidationWRTtp/HLT_general_hltAssociatorByHits
DQMData/Run 1/HLT/Run summary/Tracking/ValidationWRTtp/simulation

instead, only hltPhase2Pixel_hltAssociatorByHits is plotted. This is due to

if len(spl) != 2:
return None

Removing these lines produces the expected behaviour.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 30, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

A new Issue was created by @lguzzi.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor

assign dqm

FYI @cms-sw/tracking-pog-l2

@cmsbuild
Copy link
Contributor

New categories assigned: dqm

@rvenditti,@syuvivida,@tjavaid,@nothingface0,@antoniovagnerini you have been requested to review this Pull request/Issue and eventually sign? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants