-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate code support for HGCal v8 #27095
Comments
A new Issue was created by @kpedro88 Kevin Pedro. @davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign upgrade,geometry,simulation,reconstruction,l1,dqm |
New categories assigned: upgrade,geometry,simulation,reconstruction,l1,dqm @Dr15Jones,@cvuosalo,@mdhildreth,@mdhildreth,@jfernan2,@slava77,@andrius-k,@schneiml,@fioriNTU,@rekovic,@perrotta,@kmaeshima,@ianna,@kpedro88,@civanch,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks |
also attn: @jbsauvan |
HGCal v9 is now deprecated as well, so further usage of HCAL objects, etc. can be cleaned up in the code. |
@kpedro88 - please, let us know if this issue has not been addressed yet. Thanks! |
It has not been addressed as far as I'm aware. |
how about now? |
@kpedro88 - please, let me know if this issue is resolved. Thanks! |
@bsunanda is there more cleanup to be done for this issue? |
Hi |
Regarding the HGCal trigger part, the deprecated v8 code has been removed in #34608 |
Is this issue still valid? |
#26938 includes removing the HGCal v8 geometry, which does not have the variable silicon/scintillator boundary and uses the old DetId scheme (
HGCalDetId
for EE/FH,HcalDetId
for BH). Once this geometry is no longer supported, we could consider cleaning the code to remove the proliferation of switches to handle this old version. This would greatly simplify future development.attn: @rovere @cseez @bsunanda @clelange @felicepantaleo
The text was updated successfully, but these errors were encountered: