Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate code support for HGCal v8 #27095

Open
kpedro88 opened this issue Jun 4, 2019 · 15 comments
Open

Deprecate code support for HGCal v8 #27095

kpedro88 opened this issue Jun 4, 2019 · 15 comments

Comments

@kpedro88
Copy link
Contributor

kpedro88 commented Jun 4, 2019

#26938 includes removing the HGCal v8 geometry, which does not have the variable silicon/scintillator boundary and uses the old DetId scheme (HGCalDetId for EE/FH, HcalDetId for BH). Once this geometry is no longer supported, we could consider cleaning the code to remove the proliferation of switches to handle this old version. This would greatly simplify future development.

attn: @rovere @cseez @bsunanda @clelange @felicepantaleo

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2019

A new Issue was created by @kpedro88 Kevin Pedro.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

kpedro88 commented Jun 4, 2019

assign upgrade,geometry,simulation,reconstruction,l1,dqm

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2019

New categories assigned: upgrade,geometry,simulation,reconstruction,l1,dqm

@Dr15Jones,@cvuosalo,@mdhildreth,@mdhildreth,@jfernan2,@slava77,@andrius-k,@schneiml,@fioriNTU,@rekovic,@perrotta,@kmaeshima,@ianna,@kpedro88,@civanch,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

@kpedro88
Copy link
Contributor Author

kpedro88 commented Jun 4, 2019

also attn: @jbsauvan

@kpedro88
Copy link
Contributor Author

HGCal v9 is now deprecated as well, so further usage of HCAL objects, etc. can be cleaned up in the code.

@ianna
Copy link
Contributor

ianna commented Sep 15, 2020

@kpedro88 - please, let us know if this issue has not been addressed yet. Thanks!

@kpedro88
Copy link
Contributor Author

It has not been addressed as far as I'm aware.

@slava77
Copy link
Contributor

slava77 commented Feb 12, 2021

It has not been addressed as far as I'm aware.

how about now?

@kpedro88
Copy link
Contributor Author

#32397 removed HcalGeometry from the HGCal digitization.

There was some discussion that parts of the old geometry support had to be kept for test beam studies.

@bsunanda @rovere should comment about further cleanup plans.

@srimanob
Copy link
Contributor

Hi @bsunanda @rovere
Could you please comment about the next cleanup plan? Thanks.

@ianna
Copy link
Contributor

ianna commented Jun 22, 2021

@kpedro88 - please, let me know if this issue is resolved. Thanks!

@kpedro88
Copy link
Contributor Author

@bsunanda is there more cleanup to be done for this issue?

@jbsauvan
Copy link
Contributor

Hi
There's actually also some cleanup to do on the HGCal trigger part, which I've planned to to for a long time but never took the time to do it.
I could realistically clean before August the old v8 code there.

@jbsauvan
Copy link
Contributor

Regarding the HGCal trigger part, the deprecated v8 code has been removed in #34608

@jfernan2
Copy link
Contributor

Is this issue still valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants