Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protct the ECAL modules in the case of too many channels #478

Open
fwyzard opened this issue Jun 11, 2020 · 0 comments
Open

Protct the ECAL modules in the case of too many channels #478

fwyzard opened this issue Jun 11, 2020 · 0 comments
Assignees
@amassiro
Labels
ECAL ECAL-related developments

Comments

@fwyzard
Copy link

fwyzard commented Jun 11, 2020

Currently, the ECAL uncalibrated and rechit producers allocate a fixed-size buffer for the rechits, configurable via python.

If the number of channels to be converted is larger than the size, the modules should avoid using more memory than it is available.

Possible options:

  • dynamically extend the buffer
  • truncate the reconstructed rechits to the available memory (and print a LogError)
  • throw an exception
@fwyzard fwyzard added the ECAL ECAL-related developments label Jun 11, 2020
@amassiro amassiro mentioned this issue Jun 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amassiro amassiro

Labels
ECAL ECAL-related developments
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amassiro @fwyzard