Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset Generation #1

Open
mphalen opened this issue Jan 11, 2017 · 2 comments
Open

Dataset Generation #1

mphalen opened this issue Jan 11, 2017 · 2 comments
Assignees

Comments

@mphalen
Copy link

mphalen commented Jan 11, 2017

So there are a few options for generating propellant datasets:

A) We could scrape CEAWeb; but for each Mixture Ratio+exit pressure combination we'd need 60 plus data points (chamber pressure). So a full data set for one propellant would likely require 600+ data points, likely more.

CEAWeb has a bug where if you're defining P_Chamber/P_Exit you can only input one MR and one pressure ratio, meaning that only one data point can be pulled from a request to CEAWeb.

B) We could build a wrapper around CEA executables//use f2py to port CEA to python. This option is more feasible but possibly introduces bugs//errors into our code base. More importantly, it rather defeats the purpose of 'Open' in openrocketengine as we'd be interacting with a black box of sorts, likely with more utility than we'd need. This would make maintenance of the code base more complicated.

C) Either use or develop a computational chemistry solution that's lightweight and maintainable.

@cmflannery
Copy link
Owner

I'm leaning towards option B.
Porting CEA to python using f2py. We should test the ported version of CEA to make sure we are getting the expected values.

@cmflannery cmflannery self-assigned this Jan 27, 2017
@codeflight1
Copy link
Contributor

It looks like somebody has already done option B: https://github.com/sonofeft/RocketCEA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants