Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

Run Fetch Tests on Merge to Main #359

Merged
merged 29 commits into from
Dec 23, 2021
Merged

Run Fetch Tests on Merge to Main #359

merged 29 commits into from
Dec 23, 2021

Conversation

bbernays
Copy link
Contributor

@bbernays bbernays commented Dec 20, 2021

Closes: cloudquery-issues/issues/192

Output from acceptance testing:
This pr doesn't touch any of the provider code, it is only adding more test invocations

Notes:

The one downside of this pr is that the messages to slack say "nightly"... not sure if it is worth changing to make more generic

Copy link
Member

@disq disq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nit

resources/ec2_security_groups.go Outdated Show resolved Hide resolved
@bbernays bbernays requested a review from disq December 21, 2021 13:49
@roneli roneli merged commit 4a086ac into cloudquery:main Dec 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants