Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

ecs_task_definitions_implementation #317

Merged
merged 5 commits into from
Dec 2, 2021

Conversation

amanenk
Copy link
Contributor

@amanenk amanenk commented Nov 30, 2021

No description provided.

@amanenk amanenk requested a review from roneli November 30, 2021 12:56
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, suggested some changes.

resources/ecs_task_definitions.go Outdated Show resolved Hide resolved
resources/ecs_task_definitions.go Outdated Show resolved Hide resolved
resources/ecs_task_definitions.go Outdated Show resolved Hide resolved
@amanenk amanenk requested a review from roneli December 1, 2021 11:34
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roneli roneli merged commit 9fa9557 into cloudquery:main Dec 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants