Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

Enhance config configuratiguration recorder with status #301

Merged
merged 7 commits into from
Nov 30, 2021

Conversation

spangenberg
Copy link
Contributor

@spangenberg spangenberg added the enhancement New feature or request label Nov 25, 2021
@spangenberg spangenberg self-assigned this Nov 25, 2021
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would move the tests to a separate file, see comment in review.

client/mocks/builders_test.go Outdated Show resolved Hide resolved
@spangenberg spangenberg force-pushed the feat/enhance-configuration-recorder branch from 5bd3373 to 3a8c282 Compare November 25, 2021 09:56
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can merge after fixing @bbernays suggestion

@roneli roneli merged commit 54288e1 into main Nov 30, 2021
@roneli roneli deleted the feat/enhance-configuration-recorder branch November 30, 2021 08:44
@roneli roneli mentioned this pull request Dec 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants