Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

Add ec2.eips #284

Merged
merged 9 commits into from
Nov 24, 2021
Merged

Add ec2.eips #284

merged 9 commits into from
Nov 24, 2021

Conversation

yevgenypats
Copy link
Member

No description provided.

Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing PKS + e2e test

resources/ec2_eips.go Show resolved Hide resolved
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more comments regarding IP types

resources/ec2_eips.go Outdated Show resolved Hide resolved
resources/ec2_eips.go Outdated Show resolved Hide resolved
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should pass tests + e2e tests and we can merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants