This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
Add DMS Replication Instance #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spangenberg
force-pushed
the
feat/add-dms-replication-instance
branch
4 times, most recently
from
f490477
to
9306c2b
Compare
roneli
suggested changes
Nov 23, 2021
There was a problem hiding this comment.
LGTM would add the following https://docs.aws.amazon.com/dms/latest/APIReference/API_ListTagsForResource.html for Tags. You can pass a list of ARNs see cloudtrail for an example working with these types of APIs to reduce call overhead
spangenberg
force-pushed
the
feat/add-dms-replication-instance
branch
from
887a66f
to
e8ea5fb
Compare
roneli
approved these changes
Nov 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.