This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
fix: Panic in IsInvalidParameterValueError #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irmatov
changed the title
|
Does it fix it? why behaviour is different with explicit variable here? |
|
Looks like the original way is preferable per their docs - https://pkg.go.dev/errors can you elaborate or add a test to make sure it fix it? |
disq
reviewed
Jun 8, 2022
disq
approved these changes
Jun 8, 2022
|
Thanks for the fix @irmatov and the review @disq and @yevgenypats |
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 9, 2022
🤖 I have created a release *beep* *boop* --- ## [0.12.8](v0.12.7...v0.12.8) (2022-06-08) ### Bug Fixes * **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.11.0 ([#1023](#1023)) ([ae18dbb](ae18dbb)) * Ignore listener certs for gateway listeners ([#1005](#1005)) ([6553c8c](6553c8c)) * Lambda function Tags null ([#1016](#1016)) ([35721ba](35721ba)) * Panic in fetchRdsInstanceDbSubnetGroupSubnets ([#1020](#1020)) ([0aa25cf](0aa25cf)) * Panic in IsInvalidParameterValueError ([#1019](#1019)) ([32df59e](32df59e)) * Update endpoints ([#1025](#1025)) ([bf3e6ec](bf3e6ec)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/cloudquery/cloudquery-issues/issues/381