Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New S3 default policy breaks creation of S3 bucket #53

Closed
victor-chan-groundswell opened this issue Apr 19, 2023 · 3 comments · Fixed by #54
Closed

New S3 default policy breaks creation of S3 bucket #53

victor-chan-groundswell opened this issue Apr 19, 2023 · 3 comments · Fixed by #54
Labels
bug 🐛 An issue with the system

Comments

@victor-chan-groundswell

It would seem that Amazon is pushing S3 bucket defaults that's breaking the module.

https://aws.amazon.com/about-aws/whats-new/2023/04/amazon-s3-two-security-best-practices-buckets-default/

Unfortunately, this means that, with the combination of default settings, the s3 bucket doesn't create as it appears that the default policy that it sets in is incompatible with the bucket policy that is trying to put in.

image

I'm going to try to workaround this buy actually getting the module and tweaking the settings of the downstream s3 module to allow ACLs to see if it works.

@victor-chan-groundswell victor-chan-groundswell added the bug 🐛 An issue with the system label Apr 19, 2023
@victor-chan-groundswell
Copy link
Author

Form what I have experimented so far...., changing a setting so that I can set s3_object_ownership to "BucketOwnerPreferred" has a okay workaround....

image

in that, in the 1st TF run, I still run into this, but if I ran TF apply again a 2nd time, then everything gets applied and set.

image

I think it might have something to deal with how the cloudposse/s3-log-storage/aws module sets up the ACL....

hashicorp/terraform-provider-aws#28353

@awarner-greshamtech
Copy link

Isn't the default for the s3_object_ownership input variable already BucketOwnerPreferred?

@Nuru
Copy link
Sponsor Contributor

Nuru commented May 6, 2023

This has been fixed in the upstream terraform-aws-s3-bucket and will be fixed in the next release of this module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants