Reorganize VOLUME declarations to overcome a possible bug in Docker

[#183164582] docker/compose#3270 (comment)
cloudfoundry · Oct 4, 2022 · 1fcfe44 · 1fcfe44
1 parent c0494b1
commit 1fcfe44
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/.github/actions/run-golang-system-tests/Dockerfile b/.github/actions/run-golang-system-tests/Dockerfile
@@ -15,8 +15,9 @@ ENV MYSQL_USERNAME= \
     MYSQL_CLIENT_KEY_PATH=
 
 VOLUME /goproject
-VOLUME /mysql-certs
+
 RUN mkdir -p /mysql-certs && chmod -R 777 /mysql-certs
+VOLUME /mysql-certs
 
 RUN go install github.com/onsi/ginkgo/ginkgo@latest
 

diff --git a/.github/actions/run-golang-system-tests/mysql/Dockerfile b/.github/actions/run-golang-system-tests/mysql/Dockerfile
@@ -1,8 +1,8 @@
 ARG MYSQL_VERSION
 FROM mysql:$MYSQL_VERSION
 
-VOLUME /mysql-certs
 RUN mkdir -p /mysql-certs && chmod -R 777 /mysql-certs
+VOLUME /mysql-certs
 
 RUN mkdir -p /etc/mysql/mysql.conf.d/ && chown mysql: /etc/mysql/mysql.conf.d/
 ADD enable_mysql_tls.sh /docker-entrypoint-initdb.d/

diff --git a/.github/workflows/database-tests.yml b/.github/workflows/database-tests.yml
@@ -19,5 +19,5 @@ jobs:
         run: |
              MYSQL_VERSION="${{ matrix.mysql-version }}" \
              MYSQL_PASSWORD="$(head /dev/urandom | md5sum | cut -f1 -d" ")" \
-             docker-compose -f repo/docker-compose.yml run system-mysql || (docker-compose -f repo/docker-compose.yml logs system-mysql-backing-db && exit 1)
+             docker-compose -f repo/docker-compose.yml run system-mysql