Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure:PMKS] Return same nodegroup's names when adding a similar name's NodeGroup #993

Closed
sykim-etri opened this issue Dec 27, 2023 · 1 comment
Assignees
Labels
bug Something isn't working server

Comments

@sykim-etri
Copy link
Member

sykim-etri commented Dec 27, 2023

What happened
: 클러스터 생성시 노드그룹 이름을 ng11로 하고, 처음 addNodeGroup시 newng11로, 두번째 addNodeGroup시 newnewng11로, 세번째 addNodeGroup시 economy로, 네번째 neweconomy로 추가 요청하였을 경우 상황입니다.
NodeGroup 이름을 유사하게 입력한 경우 모두 마지막 유사 이름으로 변경되어 리턴되었고,
전혀 다른 이름인 economy로 입력한 NodeGroup과 유사 이름인 neweconomy는 정상적으로 리턴되었습니다.

{
         Name: economy,
         ImageName:/subscriptions/109a5e88-712a-48ae-9078-9ca8b3c81345/resourceGroups/AKS-Ubuntu/providers/Microsoft.Compute/galleries/AKSUbuntu/images/2204gen2containerd/versions/202312.06.0,
         ...
} [ X](javascript:removeNodeGroup('ns01-syk11', 'economy');)
----------
{
         Name: neweconomy,
         ImageName:/subscriptions/109a5e88-712a-48ae-9078-9ca8b3c81345/resourceGroups/AKS-Ubuntu/providers/Microsoft.Compute/galleries/AKSUbuntu/images/2204gen2containerd/versions/202312.06.0,
         ...
} [ X](javascript:removeNodeGroup('ns01-syk11', 'neweconomy');)
----------
{
         Name: newnewng11,
         ImageName:/subscriptions/109a5e88-712a-48ae-9078-9ca8b3c81345/resourceGroups/AKS-Ubuntu/providers/Microsoft.Compute/galleries/AKSUbuntu/images/2204gen2containerd/versions/202312.06.0,
         ...
} [ X](javascript:removeNodeGroup('ns01-syk11', 'newnewng11');)
----------
{
         Name: newnewng11,
         ImageName:/subscriptions/109a5e88-712a-48ae-9078-9ca8b3c81345/resourceGroups/AKS-Ubuntu/providers/Microsoft.Compute/galleries/AKSUbuntu/images/2204gen2containerd/versions/202312.06.0,
         ...
} [ X](javascript:removeNodeGroup('ns01-syk11', 'newnewng11');)
----------
{
         Name: newnewng11,
         ImageName:/subscriptions/109a5e88-712a-48ae-9078-9ca8b3c81345/resourceGroups/AKS-Ubuntu/providers/Microsoft.Compute/galleries/AKSUbuntu/images/2204gen2containerd/versions/202312.06.0,
         ...
} [ X](javascript:removeNodeGroup('ns01-syk11', 'newnewng11');)

neweconomy 노드그룹 추가시 cb-spider 콘솔의 로그는 다음과 같습니다.

[CB-SPIDER].[INFO]: 2023-12-27 08:17:13 Azure_CloudConnection.go:200, github.com/cloud-barista/cb-spider/cloud-control-manager/cloud-driver/drivers/azure/connect.(
*AzureCloudConnection).CreateClusterHandler() - Azure Cloud Driver: called CreateClusterHandler()!                                                                 
[CB-SPIDER].[INFO]: 2023-12-27 08:17:13 ConnectionConfigInfoManager.go:100, github.com/cloud-barista/cb-spider/cloud-info-manager/connection-config-info-manager.Ge
tConnectionConfig() - call GetConnectionConfig()                                                                                                                   
[CB-SPIDER].[INFO]: 2023-12-27 08:17:13 CommonAzureFunc.go:52, github.com/cloud-barista/cb-spider/cloud-control-manager/cloud-driver/drivers/azure/resources.GetCal
lLogScheme() - Call AZURE AddNodeGroup()                                                                                                                           
[HISCALL].[211.175.140.148] 2023-12-27 08:17:25 (Wednesday) github.com/cloud-barista/cb-spider/cloud-control-manager/cloud-driver/drivers/azure/resources.LoggingIn
fo():48 - "CloudOS" : "AZURE", "RegionZone" : "koreacentral", "ResourceType" : "CLUSTER", "ResourceName" : "ns01-syk11-cm5t80a3egvcke92an60", "CloudOSAPI" : "AddNo
deGroup()", "ElapsedTime" : "11.4614", "ErrorMSG" : ""                                                                                                             
[CB-SPIDER].[INFO]: 2023-12-27 08:17:25 CommonAzureFunc.go:52, github.com/cloud-barista/cb-spider/cloud-control-manager/cloud-driver/drivers/azure/resources.GetCal
lLogScheme() - Call AZURE GetCluster()                                                                                                                             
[HISCALL].[211.175.140.148] 2023-12-27 08:17:26 (Wednesday) github.com/cloud-barista/cb-spider/cloud-control-manager/cloud-driver/drivers/azure/resources.LoggingIn
fo():48 - "CloudOS" : "AZURE", "RegionZone" : "koreacentral", "ResourceType" : "CLUSTER", "ResourceName" : "ns01-syk11-cm5t80a3egvcke92an60", "CloudOSAPI" : "GetCl
uster()", "ElapsedTime" : "1.7686", "ErrorMSG" : ""                                                                                                                
Path: /spider/cluster/ns01-syk11/nodegroup                                                                                                                         
                                                                                                                                                                   
================================================                                                                                                                   
Request Body:                                                                                                                                                      
{                                                                                                                                                                  
  "ConnectionName": "az-krc",                                                                                                                                      
  "ReqInfo": {                                                                                                                                                     
    "Name": "neweconomy",                                                                                                                                          
    "ImageName": "",                                                                                                                                               
    "VMSpecName": "Standard_B2s",                                                                                                                                  
    "RootDiskType": "default",                                                                                                                                     
    "RootDiskSize": "default",                                                                                                                                     
    "KeyPairName": "ns01-az-krc-syk",                                                                                                                              
    "OnAutoScaling": "true",                                                                                                                                       
    "DesiredNodeSize": "1",                                                                                                                                        
    "MinNodeSize": "1",                                                                                                                                            
    "MaxNodeSize": "1"                                                                                                                                             
  }                                                                                                                                                                
}                                                                                                                                                                  
------------------------------------------------                                                                                                                   
Response Body:                                                                                                                                                     
{                                       
  "Connection": "az-krc",
  "ClusterInfo": {                      
    "IId": {                            
      "NameId": "ns01-syk11",
      "SystemId": "/subscriptions/a20fed83-96bd-4480-92a9-140b8e3b7c3a/resourcegroups/cb-tb-az-krc-syk/providers/Microsoft.ContainerService/managedClusters/ns01-sy
k11-cm5t80a3egvcke92an60"               
    },                                  
    "Version": "1.25.11",
    "Network": {                        
      "VpcIID": {                       
        "NameId": "ns01-az-krc-syk",
        "SystemId": "/subscriptions/a20fed83-96bd-4480-92a9-140b8e3b7c3a/resourceGroups/cb-tb-az-krc-syk/providers/Microsoft.Network/virtualNetworks/ns01-az-krc-sy
k-clsj71a3egva36qqt6vg"                 
      },                                
      "SubnetIIDs": [
        {                               
          "NameId": "az-krc-syk",
          "SystemId": "/subscriptions/a20fed83-96bd-4480-92a9-140b8e3b7c3a/resourceGroups/cb-tb-az-krc-syk/providers/Microsoft.Network/virtualNetworks/ns01-az-krc-
syk-clsj71a3egva36qqt6vg/subnets/az-krc-syk-clsj71a3egva36qqt700"                
        }                               
      ],                                
      "SecurityGroupIIDs": [
        {                               
          "NameId": "#aks-agentpool-11778393-nsg",                               
          "SystemId": "/subscriptions/a20fed83-96bd-4480-92a9-140b8e3b7c3a/resourceGroups/cb_cb-tb-az-krc-syk_ns01-syk11-cm5t80a3egvcke92an60_koreacentral/provider
s/Microsoft.Network/networkSecurityGroups/aks-agentpool-11778393-nsg"            
        }                               
      ],                                
      "KeyValueList": null
    },                                  
   "NodeGroupList": [                                                                                                                                  [557/63486]
      {                                                                                                                                                            
        "IId": {                                                                                                                                                   
          "NameId": "economy",                                                                                                                                     
          "SystemId": "/subscriptions/a20fed83-96bd-4480-92a9-140b8e3b7c3a/resourcegroups/cb-tb-az-krc-syk/providers/Microsoft.ContainerService/managedClusters/ns0
1-syk11-cm5t80a3egvcke92an60/agentPools/economy"                                                                                                                   
        },                                                                                                                                                         
        "ImageIID": {                                                                                                                                              
          "NameId": "/subscriptions/109a5e88-712a-48ae-9078-9ca8b3c81345/resourceGroups/AKS-Ubuntu/providers/Microsoft.Compute/galleries/AKSUbuntu/images/2204gen2c
ontainerd/versions/202312.06.0",                                                                                                                                   
          "SystemId": "/subscriptions/109a5e88-712a-48ae-9078-9ca8b3c81345/resourceGroups/AKS-Ubuntu/providers/Microsoft.Compute/galleries/AKSUbuntu/images/2204gen
2containerd/versions/202312.06.0"                                                                                                                                  
        },                                                                                                                                                         
        "VMSpecName": "Standard_B2s",                                                                                                                              
        "RootDiskType": "PremiumSSD",                                                                                                                              
        "RootDiskSize": "128",
        "KeyPairIID": {
          "NameId": "ns01-az-krc-syk",
          "SystemId": "/subscriptions/a20fed83-96bd-4480-92a9-140b8e3b7c3a/resourceGroups/cb-tb-az-krc-syk/providers/Microsoft.Network/sshPublicKeys/ns01-az-krc-sy
k-clshu7i3egva36qqt6tg"                 
        },                              
        "OnAutoScaling": true,
        "DesiredNodeSize": 1,
        "MinNodeSize": 1,
        "MaxNodeSize": 1,
        "Status": "Active",
        "Nodes": [                      
          {                             
            "NameId": "aks-economy-37950754-vmss_0",                             
            "SystemId": "/subscriptions/a20fed83-96bd-4480-92a9-140b8e3b7c3a/resourceGroups/CB_cb-tb-az-krc-syk_ns01-syk11-cm5t80a3egvcke92an60_koreacentral/provid
ers/Microsoft.Compute/virtualMachineScaleSets/aks-economy-37950754-vmss/virtualMachines/0"
          }                             
        ],                              
        "KeyValueList": null
      },                                
      {                                                                                                                                                 [522/63486]
        "IId": {                        
          "NameId": "neweconomy",
          "SystemId": "/subscriptions/a20fed83-96bd-4480-92a9-140b8e3b7c3a/resourcegroups/cb-tb-az-krc-syk/providers/Microsoft.ContainerService/managedClusters/ns0
1-syk11-cm5t80a3egvcke92an60/agentPools/neweconomy"                              
        },                              
        "ImageIID": {
          "NameId": "/subscriptions/109a5e88-712a-48ae-9078-9ca8b3c81345/resourceGroups/AKS-Ubuntu/providers/Microsoft.Compute/galleries/AKSUbuntu/images/2204gen2c
ontainerd/versions/202312.06.0",        
          "SystemId": "/subscriptions/109a5e88-712a-48ae-9078-9ca8b3c81345/resourceGroups/AKS-Ubuntu/providers/Microsoft.Compute/galleries/AKSUbuntu/images/2204gen
2containerd/versions/202312.06.0"       
        },                              
        "VMSpecName": "Standard_B2s",
        "RootDiskType": "PremiumSSD",
        "RootDiskSize": "128",
        "KeyPairIID": {
          "NameId": "ns01-az-krc-syk",
          "SystemId": "/subscriptions/a20fed83-96bd-4480-92a9-140b8e3b7c3a/resourceGroups/cb-tb-az-krc-syk/providers/Microsoft.Network/sshPublicKeys/ns01-az-krc-sy
k-clshu7i3egva36qqt6tg"                 
        },                              
        "OnAutoScaling": true,
        "DesiredNodeSize": 1,
        "MinNodeSize": 1,
        "MaxNodeSize": 1,
        "Status": "Creating",
        "Nodes": [                      
          {                             
            "NameId": "aks-neweconomy-28130201-vmss_0",                          
            "SystemId": "/subscriptions/a20fed83-96bd-4480-92a9-140b8e3b7c3a/resourceGroups/CB_cb-tb-az-krc-syk_ns01-syk11-cm5t80a3egvcke92an60_koreacentral/provid
ers/Microsoft.Compute/virtualMachineScaleSets/aks-neweconomy-28130201-vmss/virtualMachines/0"
          }                             
        ],                              
        "KeyValueList": null
      },                                
      {                                                                                                                                                 [488/63486]
        "IId": {                        
          "NameId": "newnewng11",
          "SystemId": "/subscriptions/a20fed83-96bd-4480-92a9-140b8e3b7c3a/resourcegroups/cb-tb-az-krc-syk/providers/Microsoft.ContainerService/managedClusters/ns0
1-syk11-cm5t80a3egvcke92an60/agentPools/newnewng11"                              
        },                              
        "ImageIID": {
          "NameId": "/subscriptions/109a5e88-712a-48ae-9078-9ca8b3c81345/resourceGroups/AKS-Ubuntu/providers/Microsoft.Compute/galleries/AKSUbuntu/images/2204gen2c
ontainerd/versions/202312.06.0",        
          "SystemId": "/subscriptions/109a5e88-712a-48ae-9078-9ca8b3c81345/resourceGroups/AKS-Ubuntu/providers/Microsoft.Compute/galleries/AKSUbuntu/images/2204gen
2containerd/versions/202312.06.0"       
        },                              
        "VMSpecName": "Standard_B2s",
        "RootDiskType": "PremiumSSD",
        "RootDiskSize": "128",
        "KeyPairIID": {
          "NameId": "ns01-az-krc-syk",
          "SystemId": "/subscriptions/a20fed83-96bd-4480-92a9-140b8e3b7c3a/resourceGroups/cb-tb-az-krc-syk/providers/Microsoft.Network/sshPublicKeys/ns01-az-krc-sy
k-clshu7i3egva36qqt6tg"                 
        },                              
        "OnAutoScaling": true,
        "DesiredNodeSize": 1,
        "MinNodeSize": 1,
        "MaxNodeSize": 1,
        "Status": "Active",
        "Nodes": [                      
          {                             
            "NameId": "aks-newnewng11-31630275-vmss_0",                          
            "SystemId": "/subscriptions/a20fed83-96bd-4480-92a9-140b8e3b7c3a/resourceGroups/CB_cb-tb-az-krc-syk_ns01-syk11-cm5t80a3egvcke92an60_koreacentral/provid
ers/Microsoft.Compute/virtualMachineScaleSets/aks-newnewng11-31630275-vmss/virtualMachines/0"
          }                             
        ],                              
        "KeyValueList": null
      },                                
      {                                                                                                                                                            
        "IId": {                                                                                                                                                   
          "NameId": "newnewng11",
          "SystemId": "/subscriptions/a20fed83-96bd-4480-92a9-140b8e3b7c3a/resourcegroups/cb-tb-az-krc-syk/providers/Microsoft.ContainerService/managedClusters/ns0
1-syk11-cm5t80a3egvcke92an60/agentPools/newng11"                                 
        },                              
        "ImageIID": {
          "NameId": "/subscriptions/109a5e88-712a-48ae-9078-9ca8b3c81345/resourceGroups/AKS-Ubuntu/providers/Microsoft.Compute/galleries/AKSUbuntu/images/2204gen2c
ontainerd/versions/202312.06.0",        
          "SystemId": "/subscriptions/109a5e88-712a-48ae-9078-9ca8b3c81345/resourceGroups/AKS-Ubuntu/providers/Microsoft.Compute/galleries/AKSUbuntu/images/2204gen
2containerd/versions/202312.06.0"       
        },                              
        "VMSpecName": "Standard_B2s",
        "RootDiskType": "PremiumSSD",
        "RootDiskSize": "128",
        "KeyPairIID": {
          "NameId": "ns01-az-krc-syk",
          "SystemId": "/subscriptions/a20fed83-96bd-4480-92a9-140b8e3b7c3a/resourceGroups/cb-tb-az-krc-syk/providers/Microsoft.Network/sshPublicKeys/ns01-az-krc-sy
k-clshu7i3egva36qqt6tg"                 
        },                              
        "OnAutoScaling": true,
        "DesiredNodeSize": 1,
        "MinNodeSize": 1,
        "MaxNodeSize": 1,
        "Status": "Active",
        "Nodes": [                      
          {                             
            "NameId": "aks-newng11-37242366-vmss_0",                             
            "SystemId": "/subscriptions/a20fed83-96bd-4480-92a9-140b8e3b7c3a/resourceGroups/CB_cb-tb-az-krc-syk_ns01-syk11-cm5t80a3egvcke92an60_koreacentral/provid
ers/Microsoft.Compute/virtualMachineScaleSets/aks-newng11-37242366-vmss/virtualMachines/0"
          }                             
        ],                              
        "KeyValueList": null
      },                                
      {                                 
        "IId": {                        
          "NameId": "newnewng11",
          "SystemId": "/subscriptions/a20fed83-96bd-4480-92a9-140b8e3b7c3a/resourcegroups/cb-tb-az-krc-syk/providers/Microsoft.ContainerService/managedClusters/ns0
1-syk11-cm5t80a3egvcke92an60/agentPools/ng11"                                    
        },                              
        "ImageIID": {
          "NameId": "/subscriptions/109a5e88-712a-48ae-9078-9ca8b3c81345/resourceGroups/AKS-Ubuntu/providers/Microsoft.Compute/galleries/AKSUbuntu/images/2204gen2c
ontainerd/versions/202312.06.0",        
          "SystemId": "/subscriptions/109a5e88-712a-48ae-9078-9ca8b3c81345/resourceGroups/AKS-Ubuntu/providers/Microsoft.Compute/galleries/AKSUbuntu/images/2204gen
2containerd/versions/202312.06.0"       
        },                              
        "VMSpecName": "Standard_B2s",
        "RootDiskType": "PremiumSSD",
        "RootDiskSize": "128",
        "KeyPairIID": {
          "NameId": "ns01-az-krc-syk",
          "SystemId": "/subscriptions/a20fed83-96bd-4480-92a9-140b8e3b7c3a/resourceGroups/cb-tb-az-krc-syk/providers/Microsoft.Network/sshPublicKeys/ns01-az-krc-sy
k-clshu7i3egva36qqt6tg"                 
        },                              
        "OnAutoScaling": true,
        "DesiredNodeSize": 1,
        "MinNodeSize": 1,
        "MaxNodeSize": 1,
        "Status": "Active",
        "Nodes": [                      
          {                             
            "NameId": "aks-ng11-32450294-vmss_0",                                
            "SystemId": "/subscriptions/a20fed83-96bd-4480-92a9-140b8e3b7c3a/resourceGroups/CB_cb-tb-az-krc-syk_ns01-syk11-cm5t80a3egvcke92an60_koreacentral/provid
ers/Microsoft.Compute/virtualMachineScaleSets/aks-ng11-32450294-vmss/virtualMachines/0"
          }                             
        ],                              
        "KeyValueList": null
      }                                 
    ],                                  
    "AccessInfo": ...

이때 Azure 콘솔에서는 이름이 정상적으로 등록되어 있습니다.

image

What you expected to happen
: 사용자가 입력한 이름 그대로 리턴되는 것이 필요함

How to reproduce it (as minimally and precisely as possible)
: CB-Spider Admin Web Tool에서 ng11 이름의 노드그룹으로 클러스터 생성 후, newng11 이름의 노드그룹 추가

Anything else we need to know?
:

Environment

  • Source version or branch: master/97f0bc
  • OS:
  • Others:

Proposed solution
:

Any other context
:

@sykim-etri sykim-etri added the bug Something isn't working label Dec 27, 2023
@sykim-etri sykim-etri changed the title [PMKS] return same nodegroup's NameIds when adding a similar name's NodeGroup [PMKS] return same nodegroup's names when adding a similar name's NodeGroup Dec 27, 2023
@powerkimhub powerkimhub self-assigned this Jan 2, 2024
@sykim-etri sykim-etri changed the title [PMKS] return same nodegroup's names when adding a similar name's NodeGroup [PMKS] Return same nodegroup's names when adding a similar name's NodeGroup Jan 3, 2024
@sykim-etri sykim-etri changed the title [PMKS] Return same nodegroup's names when adding a similar name's NodeGroup [Azure-PMKS] Return same nodegroup's names when adding a similar name's NodeGroup Jan 8, 2024
@sykim-etri sykim-etri changed the title [Azure-PMKS] Return same nodegroup's names when adding a similar name's NodeGroup [Azure:PMKS] Return same nodegroup's names when adding a similar name's NodeGroup Feb 15, 2024
@powerkimhub
Copy link
Member

@sykim-etri


[현황]

  • Azure NodeGroup의 경우 ID 길이가 짧아서(12char) Spider UUID(SP-XID) 처리가 어려워 처리를 하지 않습니다.
  • 이로 인하여 Azure NodeGroup의 경우 ID 길이가 사용자 입력에 따라 가변적일 수 있습니다.(다른 자원의 경우 Spide UUID 처리 및 길이 동일)
  • Azure NodeGroup의 경우 ID 길이가 다르므로, contain() 방식으로 비교하던 로직에서 현제 오류 발생 가능합니다.
    • 다른 자원들의 경우 SP-XID 처리 및 길이가 동일하여 발생하지 않음
    • ex) ng11-akxyz(10char) vs newng11-bbp(10char) - 동일하지는 않지만 이런식임

[패치]

  • Azure SystemId를 위한 Short ID 이용한 검색을 Full ID 검색 적용으로 동일한 경우가 발생하지 않도록 Fix 함
    • Short ID 의미 참고: #1355
    • Full ID 참고
      ng11:/subscriptions/a20fed83-xxx-xxx/resourcegroups/northeurope/providers/Microsoft.ContainerService/managedClusters/azure-northeu-cluster-mfj-crr919bp70irobps45m0/agentPools/ng11
      
      newng11:/subscriptions/a20fed83-xxx-xxx/resourcegroups/northeurope/providers/Microsoft.ContainerService/managedClusters/azure-northeu-cluster-mfj-crr919bp70irobps45m0/agentPools/newng11
      

[결과]

  • image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working server
Projects
None yet
Development

No branches or pull requests

2 participants