Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming the CRD's name to KamajiControlPlaneProvider #70

Open
jds9090 opened this issue Dec 12, 2023 · 2 comments
Open

Renaming the CRD's name to KamajiControlPlaneProvider #70

jds9090 opened this issue Dec 12, 2023 · 2 comments
Assignees

Comments

@jds9090
Copy link
Contributor

jds9090 commented Dec 12, 2023

The main role of Kamaji Control Plane is just for linking with CAPI. So, we need to check TCP(tenant Control Plane) if we want to check the status of control plane in detail.

That's why this repo's name is cluster-api-control-plane-provider-kamaji, not cluster-api-control-plane-kamaji.

I suggest renaming the CRD's name to KamajiControlPlaneProvider.

$: kubectl get kamajicontrolplaneprovider
NAME                       VERSION   INITIALIZED   READY   AGE
capi-quickstart   1.23.10   true          true    60d

Related to #66

@prometherion
Copy link
Member

I'm up for a discussion about this, although the renaming would be hard to tackle.

  1. You would need to create all the new resources with the new name.
  2. After that, all the TenantControlPlane instances must be patched with the right OwnerReference to the new resource
  3. Finally, the old resources can be deleted, as well as the old CRD

I'm keeping the issue open to collect feedback from other users.

@prometherion prometherion self-assigned this Dec 12, 2023
@jds9090
Copy link
Contributor Author

jds9090 commented Dec 12, 2023

I'm up for a discussion about this, although the renaming would be hard to tackle.

  1. You would need to create all the new resources with the new name.
  2. After that, all the TenantControlPlane instances must be patched with the right OwnerReference to the new resource
  3. Finally, the old resources can be deleted, as well as the old CRD

I'm keeping the issue open to collect feedback from other users.

Thank you for your consideration :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants