Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump MSRV to 1.64.0 #4615

Merged
merged 3 commits into from
Jan 9, 2023
Merged

chore: Bump MSRV to 1.64.0 #4615

merged 3 commits into from
Jan 9, 2023

Conversation

epage
Copy link
Member

@epage epage commented Jan 9, 2023

This allows using workspace inheritance which reduces the number of places we need to update on changes. Before, it was easy to remember to update the root manifest and forget the rest.

@epage epage merged commit a2e8791 into clap-rs:master Jan 9, 2023
@epage epage deleted the MSRV branch January 9, 2023 19:55
@djc
Copy link

djc commented Jan 20, 2023

So add some comments? Pushing the MSRV this aggressively for what seems like a pretty minor limitation is a real pain in the ass for downstream maintainers who would prefer to be a little more conservative about supported Rust versions.

@epage
Copy link
Member Author

epage commented Jan 20, 2023

Comments to help update things is not new to mt. We have a contributing doc and to do MSRV updates, I use comments to tag what needs updating.

Comments and documentation don't reliably scale though. I need tools and processes to keep overhead to a minimum in maintaining my 40+ crates. For example, I automate the release process with cargo-release. The other thing that has worked well is doing directory diffs to update processes between my crates, except when it comes to workspaces. This fills a lot of that gap.

@epage
Copy link
Member Author

epage commented Jan 20, 2023

Wanted to add that it was also a matter of timing since we relegate MSRV updates to minor versions and I didn't have a clear time table on when the next minor version would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants