Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rise concurrency level #94

Open
Reinmar opened this issue Dec 4, 2018 · 4 comments
Open

Rise concurrency level #94

Reinmar opened this issue Dec 4, 2018 · 4 comments

Comments

@Reinmar
Copy link
Member

Reinmar commented Dec 4, 2018

Right now we use 2-4 processes to work with multiple repos. I raised the number to 4-8 and reduced e.g. mgit update time from about 30-40% (although, more tests would need to be done). It should not make that much difference in case of normal (local) commands, where network is not involved, but those usually take considerably less time anyway.

@Reinmar
Copy link
Member Author

Reinmar commented Dec 4, 2018

I also tried 30+ threads but that did make any difference. And it actually slowed down mgit st. 4-8 seems to be safest on a typical machine.

@Reinmar
Copy link
Member Author

Reinmar commented Dec 4, 2018

@pomek Could you do ~5+ tests of the current setting and with 4-8 threads (see utils/createforkpool.js)? GH seems to give quite random numbers so we need more tests to draw conclusions.

@pomek
Copy link
Member

pomek commented Dec 5, 2018

Why can't we introduce a property that allows controlling how many threads you would like to use?

GH seems to give quite random numbers so we need more tests to draw conclusions.

That's a reason why my tests won't be good. We need to involve a people that can reproduce an error #92.

@Reinmar
Copy link
Member Author

Reinmar commented Dec 5, 2018

Why can't we introduce a property that allows controlling how many threads you would like to use?

We can. But we need sensible defaults. If you'll confirm my observations, we can assume this is a common trend. If not, we can check with more people.

@Mgsy Mgsy added this to the next milestone Jul 22, 2019
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants