-
-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribution Confirm/ThankYou.tpl cleanup #31311
base: master
Are you sure you want to change the base?
Conversation
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
<tr id="allow_auto_renew"> | ||
<td style="width: auto;">{$form.auto_renew.html}</td> | ||
<td style="width: auto;"> | ||
{$form.auto_renew.label} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not find where this auto_renew
was used in a way to display something here. It is usually set to TRUE
as a standalone variable.
It seems like maybe this supports to signup multiple memberships, but if we use a PriceSet, it does not support membership auto-renewal?
625535c
to
d448931
Compare
Ready for review. |
Without looking at the actual markup or testing, immediate response is a big thumbs up to replacing this table with divs! |
Overview
Cleanup the tpl files for Contribution Confirm and ThankYou. I tried to keep them as close as possible.
There are some very little differences in padding and markup.
Before
After
Comments
(fixed)
Includes commits from #31310 and #31299 that are not yet on master, so I am leaving it WIP for now.