Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APA: Fix missing Version label (10.10) #7151

Closed
wants to merge 10 commits into from

Conversation

rkopicki
Copy link
Contributor

@rkopicki rkopicki commented Aug 5, 2024

rkopicki and others added 10 commits July 24, 2024 13:45
… are listed

To comply with Section 10.12, the rule must support dual roles (Writer & Director) and separately list each writer and director with the appropriate role, i.e. (Writer), (Director). This may involve adding a new term "script-writer-director", similar to "editor-translator".
A CSL update to enable proper collapsing of these would be nice
- Update handling of series-creator and executive-producer
- Remove & from locale for apa-no-ampersand
- Use group to localize 'and' for media creator lists in apa-no-ampersand
Versioning schemes for computer software and mobile apps, such as semantic versioning, use version numbers that do not pass the `if is-numeric` test.
Copy link

github-actions bot commented Aug 5, 2024

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

github-actions bot commented Aug 5, 2024

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

apa-annotated-bibliography.csl (modified style; unchanged output for sample items)
(CSL Search by Example, 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example. (2012). Citation Style Editor. http://editor.citationstyles.org/searchByExample/
Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., & Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. https://doi.org/10.1038/s41597-019-0031-8
Hancké, B., Rhodes, M., & Thatcher, M. (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press.
Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall & D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage (pp. 184–213). Oxford University Press.
apa-cv.csl (modified style; unchanged output for sample items)
CSL search by example. (2012). Citation Style Editor. http://editor.citationstyles.org/searchByExample/ Hancké, B., Rhodes, M., & Thatcher, M. (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press.
Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., & Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. https://doi.org/10.1038/s41597-019-0031-8 Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall & D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage (pp. 184–213). Oxford University Press.

Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., & Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. https://doi.org/10.1038/s41597-019-0031-8
CSL search by example. (2012). Citation Style Editor. http://editor.citationstyles.org/searchByExample/
Hancké, B., Rhodes, M., & Thatcher, M. (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press.
Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall & D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage (pp. 184–213). Oxford University Press.
apa-no-ampersand.csl (modified style; unchanged output for sample items)
(CSL Search by Example, 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example. (2012). Citation Style Editor. http://editor.citationstyles.org/searchByExample/
Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., and Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. https://doi.org/10.1038/s41597-019-0031-8
Hancké, B., Rhodes, M., and Thatcher, M. (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press.
Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall and D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage (pp. 184–213). Oxford University Press.
apa-no-initials.csl (modified style; unchanged output for sample items)
(CSL Search by Example, 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example. (2012). Citation Style Editor. http://editor.citationstyles.org/searchByExample/
Fenner, Martin, Crosas, Mercè, Grethe, Jeffrey S., Kennedy, David, Hermjakob, Henning, Rocca-Serra, Phillippe, Durand, Gustavo, Berjon, Robin, Karcher, Sebastian, Martone, Maryann, & Clark, Tim. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. https://doi.org/10.1038/s41597-019-0031-8
Hancké, Bob, Rhodes, Martin, & Thatcher, Mark (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press.
Mares, Isabela. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In Peter A. Hall & David Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage (pp. 184–213). Oxford University Press.
apa-numeric-superscript-brackets.csl (modified style; unchanged output for sample items)
[1,2]
[3,4]

1. Hancké, B., Rhodes, M., & Thatcher, M. (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press.
2. CSL search by example. (2012). Citation Style Editor. http://editor.citationstyles.org/searchByExample/
3. Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall & D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage (pp. 184–213). Oxford University Press.
4. Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., & Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. https://doi.org/10.1038/s41597-019-0031-8
apa-numeric-superscript.csl (modified style; unchanged output for sample items)
1,2
3,4

1. Hancké, B., Rhodes, M., & Thatcher, M. (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press.
2. CSL search by example. (2012). Citation Style Editor. http://editor.citationstyles.org/searchByExample/
3. Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall & D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage (pp. 184–213). Oxford University Press.
4. Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., & Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. https://doi.org/10.1038/s41597-019-0031-8
apa-single-spaced.csl (modified style; unchanged output for sample items)
(CSL Search by Example, 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example. (2012). Citation Style Editor. http://editor.citationstyles.org/searchByExample/
Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., & Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. https://doi.org/10.1038/s41597-019-0031-8
Hancké, B., Rhodes, M., & Thatcher, M. (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press.
Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall & D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage (pp. 184–213). Oxford University Press.
apa-with-abstract.csl (modified style; unchanged output for sample items)
(CSL Search by Example, 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example. (2012). Citation Style Editor. http://editor.citationstyles.org/searchByExample/
Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., & Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. https://doi.org/10.1038/s41597-019-0031-8
This article presents a practical roadmap for scholarly data repositories to implement data citation in accordance with the Joint Declaration of Data Citation Principles, a synopsis and harmonization of the recommendations of major science policy bodies. The roadmap was developed by the Repositories Expert Group, as part of the Data Citation Implementation Pilot (DCIP) project, an initiative of FORCE11.org and the NIH-funded BioCADDIE (https://biocaddie.org) project. The roadmap makes 11 specific recommendations, grouped into three phases of implementation: a) required steps needed to support the Joint Declaration of Data Citation Principles, b) recommended steps that facilitate article/data publication workflows, and c) optional steps that further improve data citation support provided by data repositories. We describe the early adoption of these recommendations 18 months after they have first been published, looking specifically at implementations of machine-readable metadata on dataset landing pages.

Hancké, B., Rhodes, M., & Thatcher, M. (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press.
Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall & D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage (pp. 184–213). Oxford University Press.
apa.csl (modified style; unchanged output for sample items)
(CSL Search by Example, 2012; Hancké et al., 2007)
(Fenner et al., 2019; Mares, 2001)

CSL search by example. (2012). Citation Style Editor. http://editor.citationstyles.org/searchByExample/
Fenner, M., Crosas, M., Grethe, J. S., Kennedy, D., Hermjakob, H., Rocca-Serra, P., Durand, G., Berjon, R., Karcher, S., Martone, M., & Clark, T. (2019). A data citation roadmap for scholarly data repositories. Scientific Data, 6(1), 28. https://doi.org/10.1038/s41597-019-0031-8
Hancké, B., Rhodes, M., & Thatcher, M. (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press.
Mares, I. (2001). Firms and the welfare state: When, why, and how does social policy matter to employers? In P. A. Hall & D. Soskice (Eds.), Varieties of capitalism. The institutional foundations of comparative advantage (pp. 184–213). Oxford University Press.

@bwiernik
Copy link
Member

bwiernik commented Aug 6, 2024

Thanks, implemented a simpler update here: #7154

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Aug 6, 2024
@rkopicki
Copy link
Contributor Author

rkopicki commented Aug 6, 2024

You're the Boss!

My intention was actually to fix 10.10 compliance for computer software and mobile apps only, and to leave non-numeric version descriptions for Draft, Working Draft, Final Draft, etc., e.g. for standard, report, and document.

I see you skipped my other fix for ampersands introduced in apa-no-ampersand by a previous merge (issue #7144) - 5 ampersands in the secondary-contributors-booklike macro. N.B., there is one more ampersand in the date-legal macro (line 1934) that may need to be replaced.

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Aug 6, 2024
@github-actions github-actions bot reopened this Aug 6, 2024
@bwiernik
Copy link
Member

bwiernik commented Aug 6, 2024

For those types, it seems reasonable to always include the version label similar to the number label. Semantic versioning and similar schemes happen with those types with some regularity as well.

The ampersands were removed in a different commit.

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Aug 6, 2024
@bwiernik bwiernik closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants