-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APA: Fix missing Version label (10.10) #7151
Conversation
… are listed To comply with Section 10.12, the rule must support dual roles (Writer & Director) and separately list each writer and director with the appropriate role, i.e. (Writer), (Director). This may involve adding a new term "script-writer-director", similar to "editor-translator".
A CSL update to enable proper collapsing of these would be nice
- Update handling of series-creator and executive-producer - Remove & from locale for apa-no-ampersand - Use group to localize 'and' for media creator lists in apa-no-ampersand
Versioning schemes for computer software and mobile apps, such as semantic versioning, use version numbers that do not pass the `if is-numeric` test.
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing: If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: apa-annotated-bibliography.csl (modified style; unchanged output for sample items)(CSL Search by Example, 2012; Hancké et al., 2007) apa-cv.csl (modified style; unchanged output for sample items)CSL search by example. (2012). Citation Style Editor. http://editor.citationstyles.org/searchByExample/ Hancké, B., Rhodes, M., & Thatcher, M. (Eds.). (2007). Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford University Press. apa-no-ampersand.csl (modified style; unchanged output for sample items)(CSL Search by Example, 2012; Hancké et al., 2007) apa-no-initials.csl (modified style; unchanged output for sample items)(CSL Search by Example, 2012; Hancké et al., 2007) apa-numeric-superscript-brackets.csl (modified style; unchanged output for sample items)[1,2] apa-numeric-superscript.csl (modified style; unchanged output for sample items)1,2 apa-single-spaced.csl (modified style; unchanged output for sample items)(CSL Search by Example, 2012; Hancké et al., 2007) apa-with-abstract.csl (modified style; unchanged output for sample items)(CSL Search by Example, 2012; Hancké et al., 2007) apa.csl (modified style; unchanged output for sample items)(CSL Search by Example, 2012; Hancké et al., 2007) |
Thanks, implemented a simpler update here: #7154 |
You're the Boss! My intention was actually to fix 10.10 compliance for computer software and mobile apps only, and to leave non-numeric version descriptions for Draft, Working Draft, Final Draft, etc., e.g. for I see you skipped my other fix for ampersands introduced in |
For those types, it seems reasonable to always include the version label similar to the number label. Semantic versioning and similar schemes happen with those types with some regularity as well. The ampersands were removed in a different commit. |
if is-numeric
test.