Injection for requests.Session #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables the optional injection of the requests.Session object wrapped by RestSession. Operations teams have use cases for modifying the underlying Session behavior, chief of which is to tweak the HTTP retry policy. Currently, we're monkey-patching our own Session object into the RestSession instance; with this PR, we (and other teams) would be able to perform the same thing without violating software contracts.I can share code examples of how and why we need to do this. Author: Andrew Schenck <aschenck@cisco.com>
|
See: #149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables the optional injection of the requests.Session object wrapped by RestSession. Operations teams have use cases for modifying the underlying Session behavior, chief of which is to tweak the HTTP retry policy. Currently, we're monkey-patching our own Session object into the RestSession instance; with this PR, we (and other teams) would be able to perform the same thing without violating software contracts.
Author: Andrew Schenck aschenck@cisco.com