Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scheduled sorting/filtering bug on started and stopped views in rtorrent #19

Closed
chros73 opened this issue Jul 6, 2016 · 0 comments
Closed

Fix scheduled sorting/filtering bug on started and stopped views in rtorrent #19

chros73 opened this issue Jul 6, 2016 · 0 comments
Labels
bug important
Milestone
1.3-0.9.6

Comments

@chros73
Copy link
Owner

chros73 commented Jul 6, 2016 •
edited
Loading

started and stopped views are special in rtorrent.
If view.filter or view.sort method is scheduled on one of them then it triggers massive scheduler bug that leads to various tracker communication problems (at least).
Actually the main cause of this is view.filter.

Solution: ignore view.filter method with started and stopped views. (These views aren't filtered by default anyway and if one tries to do it then it triggers this bug.)

(Refers to: rakshasa/rtorrent#449 )
@chros73 chros73 added the bug label Jul 6, 2016
chros73 pushed a commit that referenced this issue Jul 6, 2016
Fix scheduled sorting on started and stopped views in rtorrent (See #19)
18ea5d3
chros73 pushed a commit that referenced this issue Jul 6, 2016
Fix scheduled sorting on started and stopped views in rtorrent (See #19)
69048de
chros73 pushed a commit that referenced this issue Jul 6, 2016
Fix silly condition bug in Fixing scheduled sorting on started and st…
2bfe19a 
…opped views in rtorrent (See #19)
chros73 pushed a commit that referenced this issue Jul 6, 2016
Fix filtering started and stopped views in rtorrent (See #19)
db273a4
@chros73 chros73 changed the title Fix scheduled sorting on started and stopped views in rtorrent Fix scheduled sorting/filtering bug on started and stopped views in rtorrent Jul 6, 2016
chros73 pushed a commit that referenced this issue Jul 7, 2016
Fix filtering started and stopped views in rtorrent (See #19)
c358909
@chros73 chros73 closed this as completed Jul 7, 2016
@chros73 chros73 mentioned this issue Jul 7, 2016
Closed
chros73 pushed a commit that referenced this issue Jul 8, 2016
Fix filtering started and stopped views in rtorrent (See #19)
34c4f7a
@chros73 chros73 mentioned this issue Jul 8, 2016
Merged
@chros73 chros73 added this to the 1.3-0.9.6 milestone Jul 11, 2016
zmike808 pushed a commit to zmike808/rtorrent-ps-ch that referenced this issue May 18, 2019
@chros73 @pyroscope
Fix filtering started and stopped views in rtorrent (See chros73#19) (c…
ff4b784 
…hros73#36)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug important
Projects
None yet
Milestone
1.3-0.9.6
Development

No branches or pull requests
1 participant
@chros73