Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Combine queryTexts and queryEmbeddings into a single query field in the interface for the queryRecords method. #2483

Open
AlabasterAxe opened this issue Jul 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@AlabasterAxe
Copy link
Contributor

Describe the problem

Today, in the JS client library at least, the there is a queryTexts property and a queryEmbeddings property. The logic of the client is such that exactly one of them need to be supplied.

Describe the proposed solution

I think it would clean up the interface a bit and make it clearer to callers if there were just a single query that could accept either queryTexts or queryEmbeddings and do the right thing according to whether it was an array of strings or an array of array of numbers supplied.

Alternatives considered

No response

Importance

nice to have

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant