Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] Update types.py to accommodate Numpy 2.0: np.float_ -> np.float16 #2419

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CHORE] Update types.py to accommodate Numpy 2.0: np.float_ -> np.float16 #2419

wants to merge 1 commit into from

Conversation

startakovsky
Copy link

This closes #2418

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@startakovsky startakovsky changed the title Update types.py to accommodate Numpy 2.0: np.float_ -> np.float16 [CHORE] Update types.py to accommodate Numpy 2.0: np.float_ -> np.float16 Jun 26, 2024
@startakovsky
Copy link
Author

@jeffchuber I updated the title of the PR, can we merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Attritube Error due to NumPy2.0. release.
1 participant
@startakovsky