-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Update][Ease of Use] TypeScript Client Update #2333
Comments
Quick update here: I've started to ramp back up on the Javascript client / describe the scope of work. I've started to block out a shape of the client that would be more idiomatic IMO but don't have anything concrete to share yet. Shooting to have a project breakdown by EOD Monday. |
@atroyn I've fleshed out phase 1 for this work which is the work to make the client more idiomatic: https://docs.google.com/document/d/1DH9Gl5UQeuDr6vyGgoYUw0TkBxITgXIutZSU-ZYdP_E/edit For the feature parity work, I just have placeholders while I work on understanding the new requirements better. If you're happy to leave that underspecified while I start work on the JS client improvements, I'll get started. Otherwise, I'll spend more time to understand the scope of the work more completely. Regardless, it would be useful to understand the roadmap on the Python side and for me to see examples of how these features work in Python. I'd appreciate any additional places you can point me to to learn more. Thanks! |
@AlabasterAxe I think we can get started on the improvements, and discuss runway along the way. |
Have reviewed the proposed changes.
- |
Quick update here: I got some time today to update my PR in response to the above feedback. I've got the implementation pretty much down. I've updated all the unit tests to use the new client and now I'm just going through and getting the existing tests to pass. It's been a little slow to fix the tests at first but I figure it'll speed up as I iron out the issues. Shooting for end of week to have a PR ready for review. |
@atroyn I've got a PR that I think is ready for review and the tests are passing. I think it would be good to check in on what the process for validating and launching this might be. One question I have is how it works with documentation? Do I need to update the documentation simultaneously with this PR or is it okay to do that after this PR is merged? |
@atroyn BTW I've updated that PR with the following changes:
I believe the PR should be pretty much ready to go pending feedback from review. |
Thanks @AlabasterAxe - @codetheweb and I will review this week. |
TypeScript Client Update
Chroma's first-party TypeScript client is not very idiomatic / nice to use out of the box with TypeScript projects. The documentation also needs and overhaul to make it clearer.
As we ship features into the Local Chroma v.0.6 milestone, we will also want to make sure that we maintain parity with the JS client.
[Complexity] Subtask
The text was updated successfully, but these errors were encountered: