Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible typo in code (or paper) #16

Open
MrEarle opened this issue Sep 23, 2021 · 0 comments
Open

Possible typo in code (or paper) #16

MrEarle opened this issue Sep 23, 2021 · 0 comments

Comments

@MrEarle
Copy link

MrEarle commented Sep 23, 2021

Hi!

I was looking at the progress monitor, which the paper shows it's calculation as:

paper_equation

But this line in the code shows a slightly different equation (one closing parenthesis changed position):

h_1_value = self.dropout(torch.sigmoid(concat_value_input) * torch.tanh(c_1))

This would translate to (in the paper notation):

code_equation

The difference is that in the first, the tanh is included within the sigmoid, and, in the second equation, it's outside the sigmoid.

Is there any major difference between using these two equations?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant