Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabIndex and Spreading Props #67

Closed
chrispcode opened this issue Nov 21, 2018 · 1 comment
Closed

TabIndex and Spreading Props #67

chrispcode opened this issue Nov 21, 2018 · 1 comment

Comments

@chrispcode
Copy link

chrispcode commented Nov 21, 2018

Expected result

I have a navigation bar with multiple links. Each link consists of text and an animated icon. When a user tabs inside the navigation, the only item that has to get focused is the link itself.

Actual result

The whole links gets focused on the first tab. The animated icon inside gets focused on second tab.

Ways to fix it:

  1. Spread the incoming props to the component down to the inner div
  2. Remove the tabIndex or make it a prop

I will be more than happy to submit a pull request, if you give me green light!
Thank you for the excellent work!

@chrispcode
Copy link
Author

Anyone looking for a solved version of this problem or a typescript version of react-lottie here is a version:
https://gist.github.com/chrispcode/2c12af4e6a8c2cca242c64559cd3fb90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant