feat: add Dockerfile to this project #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Looks good. Hope there was no good reason why it was another project |
lpatiny
approved these changes
Nov 2, 2018
stropitek
reviewed
Nov 2, 2018
|
|
||
| WORKDIR /rest-on-couch-source | ||
| COPY --from=builder /rest-on-couch-source /rest-on-couch-source | ||
| RUN npm install -g pm2 && npm ci && rm -rf /root/.npm |
There was a problem hiding this comment.
I don't really understand the point of having a multistage build in the Dockefile.
Why are you removing node_modules in the other image and redoing npm ci here?
There was a problem hiding this comment.
Here it's done with NODE_ENV set to "production". But you're right multistage is probably overkill in this case, especially now that npm ci already deletes node_modules. Feel free to improve the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by https://github.com/cheminfo/rest-on-couch-docker
Then we can archive that repo and don't need another step to publish the Docker image.