feat(views): allow reduce

Allow reduce on views that don't emit owners

src/couch/query.js

@@ -48,6 +48,8 @@ const methods = {
         const data = new Map();
         const userStartKey = options.key ? [options.key] : (options.startkey ? options.startkey : []);
         const userEndKey = options.key ? [options.key] : (options.endkey ? options.endkey : []);
+
+
         for (const group of userGroups) {
             const startkey = [group].concat(userStartKey);
             const endkey = [group].concat(userEndKey);
@@ -80,8 +82,19 @@ const methods = {
     async queryViewByUser(user, view, options, rights) {
         debug(`queryViewByUser (${user}, ${view})`);
         options = Object.assign({}, options);
+        if(options.reduce) {
+            if (this._viewsWithOwner.has(view)) {
+                // We don't allow this. Reduce with emit owner make little sense
+                // since each document can be emited more than once...
+                throw new CouchError(`${view} is a view with owner`, 'unauthorized');
+            }
+            // !! if reduce we bypass security
+            // Reduce should not contain sensible data
+            return await nanoPromise.queryView(this._db, view, options);
+        }
+
+
         options.include_docs = true;
-        options.reduce = false;
         options.skip = 0;
         var limit = options.limit || 1;
         var cumRows = [];

test/homedir/config.js

@@ -13,6 +13,16 @@ module.exports = {
                     emitWithOwner(['x', 'y', 'z'], doc.$id);
                 },
                 withOwner: true
+            },
+            testReduce: {
+                map: function (doc) {
+                    if(doc.$type === 'entry') {
+                        emit(doc._id, 1); // eslint-disable-line no-undef
+                    }
+                },
+                reduce: function(keys, values) {
+                    return sum(values);
+                }
             }
         }
     },

test/queries.js

@@ -75,7 +75,7 @@ describe('Query view with owner (group right)', function () {
     });
 });
 
-describe('Query view filter groups', function () {
+describe('Query entries filter groups', function () {
     before(noRights);
     it('should only return entries owned by the user', function () {
         return couch.queryEntriesByRight('a@a.com', 'entryIdByRight', null, {groups: 'a@a.com'})
@@ -129,6 +129,17 @@ describe('Query view filter groups', function () {
     });
 });
 
+describe('Query view with reduce', function () {
+    before(data);
+    it('Should query by user id', function () {
+        return couch.queryViewByUser('a@a.com', 'testReduce', {reduce: true})
+            .then(rows => {
+                // counts the entries
+                rows[0].value.should.equal(5);
+            });
+    });
+});
+
 function sortByValue(a, b) {
     if (a.value < b.value) return -1;
     else if (a.value > b.value) return 1;

views/login.html

@@ -63,7 +63,6 @@ <h3>CouchDB login</h3>
     }
 
     function doLogin(url) {
-        debugger;
         if(window.parent !== window) {
             url += '/popup';
             var popup = window.open(url, 'loginPopup');