Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop propagation of key events #198

Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix: stop propagation of key events #198

merged 1 commit into from
Mar 25, 2024

Conversation

targos
Copy link
Member

@targos targos commented Mar 24, 2024

Closes: #196

@targos
Copy link
Member Author

targos commented Mar 24, 2024

@lpatiny

@targos targos requested a review from lpatiny March 25, 2024 07:28
lpatiny
lpatiny approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@lpatiny lpatiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos targos merged commit bd21926 into main Mar 25, 2024
4 checks passed
@targos targos deleted the stop-propagation branch March 25, 2024 08:31
@cheminfo-bot cheminfo-bot mentioned this pull request Mar 25, 2024
Merged
@tomlebl tomlebl mentioned this pull request Jun 5, 2024
Closed
@tomlebl tomlebl mentioned this pull request Jun 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpatiny lpatiny lpatiny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keyboard events should not propagate
2 participants
@targos @lpatiny