Added clause to ignore cop UnlessDefinedRequire in rubocop.yml #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👷 Deploy Preview for chef-supermarket processing. 🔨 Explore the source changes: 7f42e3b 🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-supermarket/deploys/61fa4b92981516000797a5c2 |
Signed-off-by: smriti <sgarg@msystechnologies.com>
msys-sgarg
force-pushed
the
smriti/failures_cookstyle_due_to_chefstyle_run_fixed
branch
from
e02ba54
to
7f42e3b
Compare
saghoshprogress
approved these changes
Feb 2, 2022
saghoshprogress
deleted the
smriti/failures_cookstyle_due_to_chefstyle_run_fixed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rubocop cop -
Chef/Ruby/UnlessDefinedRequire, stops the file from loading a module in case its already loaded.This is causing issues since rails zeitwerk tries to autoload all the dependencies beforehand but in few cases the dependencies are not loaded properly and hence need to be re-loaded on the run time. This was breaking the execution of cookstyle and hence the cop is disabled.
Issues Resolved
chefstyle autocorrection in engines directory broke the running cookstyle metric feature.
Check List