-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/habitat package #2453
Feature/habitat package #2453
Conversation
👷 Deploy Preview for chef-supermarket processing. 🔨 Explore the source changes: d4a487b 🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-supermarket/deploys/6225a9502f69c90007f992cd |
90acc50
to
b20992d
Compare
https://buildkite.com/chef/chef-supermarket-main-omnibus-adhoc/builds/368 - Adhoc build passing |
Signed-off-by: smriti <sgarg@msystechnologies.com>
Signed-off-by: Siraj Rauff <sirajrauff@gmail.com>
Signed-off-by: Siraj Rauff <sirajrauff@gmail.com>
Signed-off-by: Siraj Rauff <sirajrauff@gmail.com>
Signed-off-by: Siraj Rauff <sirajrauff@gmail.com>
Signed-off-by: Siraj Rauff <sirajrauff@gmail.com>
Signed-off-by: Siraj Rauff <sirajrauff@gmail.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: smriti <sgarg@msystechnologies.com> Removed unload script Signed-off-by: smriti <sgarg@msystechnologies.com> Added allowed_host to scaffolding Signed-off-by: smriti <sgarg@msystechnologies.com> documentation for habitat setup in dev env Signed-off-by: smriti <sgarg@msystechnologies.com>
b20992d
to
d4a487b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Description
This adds the habitat packages for the rails supermarket app, the sidekiq worker as well as wrapped versions of (core/) nginx, redis and postgresql with templating/defaults for supermarket.
Note some arbitrary things that may want to be modified after this PR is merged:
Naming of habitat packages
Currently supermarket and supermarket- this could be supermarket-rails and the component ones may drop the prefix - this depends on the team's preference
Location of habitat packages
habitat-web for rails and habitat-sidekiq for the worker are both included in the source code directory at src/supermarket, while components remain at the top level for nginx, redis and postgresql. These may make more sense in a top-level packages directory or even in separate repositories
Issues Resolved
[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]
Check List