Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/habitat package #2453

Merged
merged 10 commits into from
Mar 21, 2022
Merged

Feature/habitat package #2453

merged 10 commits into from
Mar 21, 2022

Conversation

saghoshprogress
Copy link
Contributor

Description

This adds the habitat packages for the rails supermarket app, the sidekiq worker as well as wrapped versions of (core/) nginx, redis and postgresql with templating/defaults for supermarket.

Note some arbitrary things that may want to be modified after this PR is merged:

Naming of habitat packages
Currently supermarket and supermarket- this could be supermarket-rails and the component ones may drop the prefix - this depends on the team's preference
Location of habitat packages
habitat-web for rails and habitat-sidekiq for the worker are both included in the source code directory at src/supermarket, while components remain at the top level for nginx, redis and postgresql. These may make more sense in a top-level packages directory or even in separate repositories

Issues Resolved

[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]

Check List

@saghoshprogress saghoshprogress requested review from a team as code owners December 21, 2021 10:27
@netlify
Copy link

netlify bot commented Dec 21, 2021

👷 Deploy Preview for chef-supermarket processing.

🔨 Explore the source changes: d4a487b

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-supermarket/deploys/6225a9502f69c90007f992cd

@msys-sgarg msys-sgarg force-pushed the feature/habitat_package branch 3 times, most recently from 90acc50 to b20992d Compare February 23, 2022 11:50
@msys-sgarg
Copy link
Contributor

@msys-sgarg
Copy link
Contributor

@msys-sgarg msys-sgarg changed the title WIP : Feature/habitat package Feature/habitat package Feb 25, 2022
nginx/README.md Outdated Show resolved Hide resolved
nginx/README.md Outdated Show resolved Hide resolved
msys-sgarg and others added 10 commits March 3, 2022 17:45
Signed-off-by: smriti <sgarg@msystechnologies.com>
Signed-off-by: Siraj Rauff <sirajrauff@gmail.com>
Signed-off-by: Siraj Rauff <sirajrauff@gmail.com>
Signed-off-by: Siraj Rauff <sirajrauff@gmail.com>
Signed-off-by: Siraj Rauff <sirajrauff@gmail.com>
Signed-off-by: Siraj Rauff <sirajrauff@gmail.com>
Signed-off-by: Siraj Rauff <sirajrauff@gmail.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: saghoshprogress <saghosh@progress.com>
Signed-off-by: smriti <sgarg@msystechnologies.com>

Removed unload script

Signed-off-by: smriti <sgarg@msystechnologies.com>

Added allowed_host to scaffolding

Signed-off-by: smriti <sgarg@msystechnologies.com>

documentation for habitat setup in dev env

Signed-off-by: smriti <sgarg@msystechnologies.com>
Copy link
Contributor

@msys-sgarg msys-sgarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@saghoshprogress saghoshprogress merged commit 8f4bfc5 into main Mar 21, 2022
@saghoshprogress saghoshprogress deleted the feature/habitat_package branch March 21, 2022 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants