-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change chef downloads url #2449
Conversation
Signed-off-by: Manick Vel <mkumaravel@msystechnologies.com>
✔️ Deploy Preview for chef-supermarket ready! 🔨 Explore the source changes: 9f76e92 🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-supermarket/deploys/61cd9677653c790008f67f1f 😎 Browse the preview: https://deploy-preview-2449--chef-supermarket.netlify.app |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure we get the www. in there as well
@@ -38,7 +38,7 @@ def chef_docs_url(extra = nil) | |||
end | |||
|
|||
def chef_downloads_url(extra = nil) | |||
url = ENV["CHEF_DOWNLOADS_URL"] || "https://downloads.#{chef_domain}" | |||
url = ENV["CHEF_DOWNLOADS_URL"] || "https://#{chef_domain}/downloads" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to be missing the www?
@@ -74,7 +74,7 @@ | |||
|
|||
describe "downloads url" do | |||
let(:meth) { :chef_downloads_url } | |||
let(:url) { "https://downloads.chef.io" } | |||
let(:url) { "https://chef.io/downloads" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let(:url) { "https://chef.io/downloads" } | |
let(:url) { "https://www.chef.io/downloads" } |
@@ -38,7 +38,7 @@ def chef_docs_url(extra = nil) | |||
end | |||
|
|||
def chef_downloads_url(extra = nil) | |||
url = ENV["CHEF_DOWNLOADS_URL"] || "https://downloads.#{chef_domain}" | |||
url = ENV["CHEF_DOWNLOADS_URL"] || "https://#{chef_domain}/downloads" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url = ENV["CHEF_DOWNLOADS_URL"] || "https://#{chef_domain}/downloads" | |
url = ENV["CHEF_DOWNLOADS_URL"] || "https://www.#{chef_domain}/downloads" |
Signed-off-by: Manick Vel <mkumaravel@msystechnologies.com>
Signed-off-by: Manick Vel mkumaravel@msystechnologies.com
Description
Change chef downloads url from downloads.chef.io to https://www.chef.io/downloads
Issues Resolved
#2350
Check List